Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set surface values to zero if all are masked #594

Merged
merged 3 commits into from
Mar 24, 2021
Merged

Set surface values to zero if all are masked #594

merged 3 commits into from
Mar 24, 2021

Conversation

HansKallekleiv
Copy link
Collaborator

@HansKallekleiv HansKallekleiv commented Mar 23, 2021 •
edited
Loading

Contributor checklist

  • 🎉 This PR closes SurfaceViewerFMU should handle surfaces with only undefined values #562 .
  • 📜 I have broken down my PR into the following tasks:
    • Set surface values to zero if all values are masked
  • 🤖 I have added tests, or extended existing tests, to cover any new features or bugs fixed in this PR.
  • 📖 I have considered adding a new entry in CHANGELOG.md, and added it if should be communicated there.

@HansKallekleiv HansKallekleiv force-pushed the handle-undefined-surf-values branch from 66ca9db to e58682b Compare March 23, 2021 15:51
@HansKallekleiv HansKallekleiv added this to the Komodo April release milestone Mar 23, 2021
@HansKallekleiv HansKallekleiv merged commit 726893c into equinor:master Mar 24, 2021
@HansKallekleiv HansKallekleiv deleted the handle-undefined-surf-values branch March 24, 2021 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anders-kiaer anders-kiaer anders-kiaer approved these changes

@asnyv asnyv Awaiting requested review from asnyv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Komodo April release
Development

Successfully merging this pull request may close these issues.

SurfaceViewerFMU should handle surfaces with only undefined values
2 participants
@HansKallekleiv @anders-kiaer