Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort rft dataframe by dates #498

Merged
merged 1 commit into from
Nov 26, 2020
Merged

Sort rft dataframe by dates #498

merged 1 commit into from
Nov 26, 2020

Conversation

tnatt
Copy link
Collaborator

@tnatt tnatt commented Nov 26, 2020 •
edited
Loading

Contributor checklist

  • 🎉 This PR closes RFT-plotter: Dates in date-slider in wrong order  #497 .
  • 📜 I have broken down my PR into the following tasks:
    • Task 1: Sort dataframe by dates
  • 🤖 I have added tests, or extended existing tests, to cover any new features or bugs fixed in this PR.
  • 📖 I have considered adding a new entry in CHANGELOG.md, and added it if should be communicated there.

anders-kiaer
anders-kiaer approved these changes Nov 26, 2020
View reviewed changes
Copy link
Collaborator

@anders-kiaer anders-kiaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🐞

@anders-kiaer anders-kiaer merged commit bc64c7c into equinor:master Nov 26, 2020
VincentNevermore pushed a commit to VincentNevermore/webviz-subsurface that referenced this pull request Jul 19, 2022
@alexandruandrei91
Add all the needed files in the npm package (equinor#498)
c08d398
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anders-kiaer anders-kiaer anders-kiaer approved these changes

@asnyv asnyv Awaiting requested review from asnyv

@HansKallekleiv HansKallekleiv Awaiting requested review from HansKallekleiv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RFT-plotter: Dates in date-slider in wrong order
2 participants
@tnatt @anders-kiaer