Check if scratch ensemble is empty #457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asnyv
reviewed
Sep 29, 2020
webviz_subsurface/__init__.py
Outdated
| f"Ensemble {ensemble_name} is said to be located at {ensemble_path}," | ||
| " but that wildcard path does not give any matches." | ||
| f"No realizations with a valid target file ('OK') found for ensemble " | ||
| f"{ensemble_name} located at {ensemble_path}. " |
There was a problem hiding this comment.
Add something even more explicit? E.g. "This can e.g. occur when running ERT if no simulations are finished, or all simulations failed."?
HansKallekleiv
force-pushed
the
ens-warning
branch
from
c4779c6 to
82bc800
Compare
asnyv
requested changes
Sep 29, 2020
HansKallekleiv
force-pushed
the
ens-warning
branch
from
82bc800 to
fa89bbd
Compare
anders-kiaer
requested changes
Sep 29, 2020
HansKallekleiv
force-pushed
the
ens-warning
branch
3 times, most recently
from
5accaf0 to
00e6239
Compare
anders-kiaer
approved these changes
Sep 30, 2020
webviz_subsurface/__init__.py
Outdated
| " but that wildcard path does not give any matches." | ||
| f"No realizations with a valid target file ('OK') found for ensemble " | ||
| f"{ensemble_name} located at {ensemble_path}. This can occur when running " | ||
| "ERT if no simulations are finished, or all simulations has failed." |
There was a problem hiding this comment.
Suggested change
| "ERT if no simulations are finished, or all simulations has failed." | |
| "ERT if no simulations are finished, or all simulations have failed." |
HansKallekleiv
force-pushed
the
ens-warning
branch
from
00e6239 to
ab0ee84
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--
Contributor checklist