Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use new Leaflet Map component #420

Merged
merged 1 commit into from
Sep 7, 2020
Merged

Use new Leaflet Map component #420

merged 1 commit into from
Sep 7, 2020

Conversation

HansKallekleiv
Copy link
Collaborator

Closes #397

@HansKallekleiv HansKallekleiv marked this pull request as draft August 27, 2020 10:07
@anders-kiaer anders-kiaer marked this pull request as ready for review September 7, 2020 08:17
@anders-kiaer
Copy link
Collaborator

anders-kiaer commented Sep 7, 2020 •
edited
Loading

Nice @HansKallekleiv! 😎🚀

Should we just 🔪 away webviz_subsurface.image_processing.get_colormap now? I guess that is not used anymore by webviz-subsurface?

Potentialy we can now probably also get rid of some import time now, and MB of uncompressed matplotlib install files as well in the 🐳 Docker image. I think our actual usage of matplotlib is small, and especially after this PR (as far as I can see only ListedColorMap, which I guess we easily can do ourselves or using plotly 🐍 functionality?). I'm open for removing maptlotlib in a separate PR (doesn't have to be this one).

anders-kiaer
anders-kiaer approved these changes Sep 7, 2020
View reviewed changes
Copy link
Collaborator

@anders-kiaer anders-kiaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Squash some commits, and then this is ready to go! 🚀 👍

@HansKallekleiv HansKallekleiv merged commit 2b8c931 into equinor:master Sep 7, 2020
@HansKallekleiv HansKallekleiv deleted the new-map branch September 7, 2020 14:12
@anders-kiaer anders-kiaer mentioned this pull request Sep 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anders-kiaer anders-kiaer anders-kiaer approved these changes

@asnyv asnyv Awaiting requested review from asnyv

Assignees
No one assigned
Labels
None yet
Projects
Webviz
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use new Map component
2 participants
@HansKallekleiv @anders-kiaer