Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Dash 1.11 #322

Merged
merged 3 commits into from
Apr 28, 2020
Merged

Conversation

HansKallekleiv
Copy link
Collaborator

@HansKallekleiv HansKallekleiv commented Apr 27, 2020

Closes #317

Fixes related to Dash 1.11.

  • We used some wrong component props in callbacks that are no longer allowed in Dash 1.11. E.g. dcc.Store(children) should be dcc.Store(data).
  • There is a breaking change in Dash 1.11 when using callback_context.triggered. It is no longer possible to identify which input parameters triggers the first time a callback is executed. A check for this has been added to the necessary callbacks.

Copy link
Collaborator

@anders-kiaer anders-kiaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment only. Otherwise LGTM 🎉

@anders-kiaer anders-kiaer self-requested a review April 28, 2020 07:48
@HansKallekleiv HansKallekleiv merged commit 2c1f1c5 into equinor:master Apr 28, 2020
@HansKallekleiv HansKallekleiv deleted the fix-dash111 branch April 28, 2020 07:50
VincentNevermore pushed a commit to VincentNevermore/webviz-subsurface that referenced this pull request Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Master failing with Dash 1.11
2 participants