Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split settings groups in RftPlotter #1180

Merged
merged 6 commits into from
Dec 5, 2022
Merged

Split settings groups in RftPlotter #1180

merged 6 commits into from
Dec 5, 2022

Conversation

lindjoha
Copy link
Collaborator

Splits the previous Selection settings group into PlotType and Ensembles.

Contributor checklist

  • 🎉 This PR closes #ISSUE_NUMBER.
  • 📜 I have broken down my PR into the following tasks:
    • Task 1
    • Task 2
  • 🤖 I have added tests, or extended existing tests, to cover any new features or bugs fixed in this PR.
  • 📖 I have considered adding a new entry in CHANGELOG.md, and added it if should be communicated there.

anders-kiaer
anders-kiaer approved these changes Dec 2, 2022
View reviewed changes
Copy link
Collaborator

@anders-kiaer anders-kiaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! One small comment only 🙂

webviz_subsurface/plugins/_rft_plotter/_views/_sim_vs_obs_view/_settings/_ensembles.py Outdated Show resolved Hide resolved
@anders-kiaer anders-kiaer added enhancement 🚀 New feature or request next release 🚢 To be included in next release labels Dec 2, 2022
@lindjoha lindjoha merged commit 0bc4814 into equinor:master Dec 5, 2022
@lindjoha lindjoha deleted the rft_impr branch April 14, 2023 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anders-kiaer anders-kiaer anders-kiaer approved these changes

Assignees
No one assigned
Labels
enhancement 🚀 New feature or request next release 🚢 To be included in next release
Projects
Webviz
Status: Done 🏁
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lindjoha @anders-kiaer