Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vtk modules are added to extras_require #1166

Merged
merged 2 commits into from
Nov 18, 2022
Merged

Conversation

asnyv
Copy link
Collaborator

@asnyv asnyv commented Nov 18, 2022

webviz_vtk is not yet a PyPi package and can therefore not be part of the regular release (not sure if it will be a problem to have it in extras_require too? But guess the easiest way to find out is to test.

@asnyv asnyv requested a review from anders-kiaer November 18, 2022 07:51
@asnyv asnyv force-pushed the vtk_extra branch 3 times, most recently from 43b3517 to 0326746 Compare November 18, 2022 08:18
@asnyv asnyv requested a review from HansKallekleiv November 18, 2022 08:39
@anders-kiaer anders-kiaer changed the title vtk modules are added to extras_require vtk modules are added to extras_require Nov 18, 2022
Copy link
Collaborator

@anders-kiaer anders-kiaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@asnyv asnyv merged commit 168c55a into equinor:master Nov 18, 2022
@asnyv asnyv deleted the vtk_extra branch November 18, 2022 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants