Remove direct import from SimulationTimeSeries utilities
#1161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anders-kiaer
changed the title
SimulationTimeSeries utilities
anders-kiaer
approved these changes
Nov 17, 2022
…ries - Move definition of ProviderSet til webviz_subsurface/_utils - Move provider set create methods and rename file webviz_subsurface/_utils/provider_set_factory.py - Remove webvis_subsurface/_utils/datetime_utils.py as it should not be a common util. Due to limitation of date data frequency of daily it can be misused and one can loose date content. It should be handled specific in plugins. - Update imports accordingly - Update unit test file placement accordingly
- Rename as the `ProviderSet` is moved out of SimulationTimeSeries scope. webviz-subsurface has multiple type of providers in `_providers`, thereby the type of provider is specified in naming when the utility is moved to top-level `utils` folder - Update imports and file-naming accordingly
jorgenherje
force-pushed
the
EQ_1106-move-simulation-time-series-utilities
branch
from
65e1a1b to
5e69950
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various plugins performs direct import of utility objects/functions from
SimulationTimeSeries.Move the respective utils to a common top-level utility folder. Utilities which are too general, and does not belong in the top-level utility folder, are moved into the specific plugins to prevent misusage.
Done:
ProviderSettowebviz_subsurface/_utilsfor common usage.ProviderSettoEnsembleSummaryProviderSetas the utility is now moved out of scope ofSimulationTimeSeries. There are multipleprovidersinwebviz-subsurfaceand a common utility must clarify its scope - i.e. set forEnsembleSummaryProvider.names()-method is renamed toprovider_names()for clarity.EnsembleSummaryProviderinterface across all provides in set.ProviderSetcreator methods towebviz_subsurface/_utilsensemble_summary_provider_set_factory.pyaccording to renaming toEnsembleSummaryProviderSetwebviz_subsurface/_utils/datetime_utils.pySimulationTimeSeries-plugin folder. The implementations assumes data with daily frequency, thus the date conversionto_strandfrom_strmethods can result in loss of data if date frequency is higher than daily. This should not be common utility methods. File deleted and utility methods added directly in respective plugins.Closes: #1106