Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace wcc.LabeledContainer with wcc.Selectors for Delta Ensembles in SimulationTimeSeries #1153

Conversation

jorgenherje
Copy link
Collaborator

Place the Delta Ensembles in a wcc.Selectors component rather than a wcc.LabeledContainer to obtain open/close functionality.

Requested by users: wcc.Selectors rather than Delta Ensembles as a separate WebvizSettingsGroup in the settings drawer for WLF - to keep the Delta Ensemble functionality grouped with the Ensembles.

Closes: #1151

@jorgenherje jorgenherje added the enhancement 🚀 New feature or request label Nov 8, 2022
@jorgenherje jorgenherje requested review from asnyv and lindjoha November 8, 2022 07:37
@jorgenherje jorgenherje self-assigned this Nov 8, 2022
@jorgenherje jorgenherje force-pushed the EQ_1151-delta-ensembles-in-wcc-selectors branch from 77cb171 to 39599db Compare November 8, 2022 11:44
Copy link
Collaborator

@lindjoha lindjoha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jorgenherje jorgenherje merged commit 10aa88e into equinor:master Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🚀 New feature or request
Projects
Status: Done 🏁
Development

Successfully merging this pull request may close these issues.

Place Delta Ensembles settings for SimulationTimeSeries into a wcc.Selectors
2 participants