-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metadata functionality in EnsembleTableProvider
#1135
Merged
anders-kiaer
merged 10 commits into
equinor:master
from
lindjoha:ensemble_table_provider_metadata
Oct 27, 2022
Merged
Metadata functionality in EnsembleTableProvider
#1135
anders-kiaer
merged 10 commits into
equinor:master
from
lindjoha:ensemble_table_provider_metadata
Oct 27, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sigurdp
reviewed
Oct 24, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some comments related to method and class naming as well as behavior in the presence of partial meta data.
webviz_subsurface/_providers/ensemble_table_provider/ensemble_table_provider.py
Outdated
Show resolved
Hide resolved
webviz_subsurface/_providers/ensemble_table_provider/_field_metadata.py
Outdated
Show resolved
Hide resolved
webviz_subsurface/_providers/ensemble_table_provider/ensemble_table_provider.py
Outdated
Show resolved
Hide resolved
sigurdp
approved these changes
Oct 27, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go
lindjoha
force-pushed
the
ensemble_table_provider_metadata
branch
from
October 27, 2022 07:57
4785da8
to
afbba0f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the possibility to extract column metadata from the
EnsembleTableProvider
. It is needed in theWellCompletion
plugin to get the KH unit.Only unit is so far implemented, but it is easily extended to other column metadata
Contributor checklist
CHANGELOG.md
, and added it if should be communicated there.