Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata functionality in EnsembleTableProvider #1135

Merged
merged 10 commits into from
Oct 27, 2022

Conversation

lindjoha
Copy link
Collaborator

Implements the possibility to extract column metadata from the EnsembleTableProvider. It is needed in the WellCompletion plugin to get the KH unit.

Only unit is so far implemented, but it is easily extended to other column metadata


Contributor checklist

  • 🎉 This PR closes #ISSUE_NUMBER.
  • 📜 I have broken down my PR into the following tasks:
    • Task 1
    • Task 2
  • 🤖 I have added tests, or extended existing tests, to cover any new features or bugs fixed in this PR.
  • 📖 I have considered adding a new entry in CHANGELOG.md, and added it if should be communicated there.

Copy link
Collaborator

@sigurdp sigurdp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments related to method and class naming as well as behavior in the presence of partial meta data.

@lindjoha lindjoha requested a review from sigurdp October 24, 2022 16:17
Copy link
Collaborator

@sigurdp sigurdp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go

@lindjoha lindjoha force-pushed the ensemble_table_provider_metadata branch from 4785da8 to afbba0f Compare October 27, 2022 07:57
@anders-kiaer anders-kiaer merged commit 59a1e10 into equinor:master Oct 27, 2022
@lindjoha lindjoha deleted the ensemble_table_provider_metadata branch April 14, 2023 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants