Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix callback_typecheck error for wcc.Dialog prop in SimulationTimeSeries #1121

Conversation

jorgenherje
Copy link
Collaborator

open is not required prop for wcc.Dialog, thus initial value was undefined, and the data type was undefined - i.e None. Resolved by defining initial state False, thus open.propType = boolean in React-component and python type is bool.

- open is not required prop for wcc.Dialog, thus initial value was
undefined. Resolved by defining initial state False, thus
propType = boolean
@jorgenherje jorgenherje added the bug 🐛 Something isn't working label Oct 3, 2022
@jorgenherje jorgenherje self-assigned this Oct 3, 2022
@anders-kiaer anders-kiaer changed the title Fix callback_typecheck error for wcc.Dialog prop in SimulationTimeSeries Fix callback_typecheck error for wcc.Dialog prop in SimulationTimeSeries Oct 3, 2022
Copy link
Collaborator

@anders-kiaer anders-kiaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@anders-kiaer anders-kiaer added the next release 🚢 To be included in next release label Oct 3, 2022
@jorgenherje jorgenherje merged commit b3702ca into equinor:master Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working next release 🚢 To be included in next release
Projects
Status: Done 🏁
Development

Successfully merging this pull request may close these issues.

2 participants