Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Well analysis trail #1089

Merged
merged 33 commits into from
Sep 15, 2022
Merged

Well analysis trail #1089

merged 33 commits into from
Sep 15, 2022

Conversation

EirikPeirik
Copy link
Contributor

@EirikPeirik EirikPeirik commented Jul 25, 2022 •
edited by lindjoha
Loading

This PR transfers the WellAnalysis plugin to WLF.

I have removed the well attributes filtering for now, plan to re-introduce them when the new AttributeSelector becomes available.

Contributor checklist

  • 🎉 This PR closes WellAnalysis to WLF #1067 .
  • 📜 I have broken down my PR into the following tasks:
    • Task 1
    • Task 2
  • 🤖 I have added tests, or extended existing tests, to cover any new features or bugs fixed in this PR.
  • 📖 I have considered adding a new entry in CHANGELOG.md, and added it if should be communicated there.

@JinCheng2022 JinCheng2022 self-requested a review August 3, 2022 11:36
JinCheng2022
JinCheng2022 reviewed Aug 3, 2022
View reviewed changes
webviz_subsurface/plugins/_well_analysis/_plugin_ids.py Outdated Show resolved Hide resolved
webviz_subsurface/plugins/_well_analysis/_plugin_ids.py Outdated Show resolved Hide resolved
webviz_subsurface/plugins/_well_analysis/_views/_settings.py Outdated Show resolved Hide resolved
webviz_subsurface/plugins/_well_analysis/_views/_settings.py Outdated Show resolved Hide resolved
webviz_subsurface/plugins/_well_analysis/_views/_settings.py Outdated Show resolved Hide resolved
webviz_subsurface/plugins/_well_analysis/_views/_settings.py Outdated Show resolved Hide resolved
webviz_subsurface/plugins/_well_analysis/_views/_well_control.py Outdated Show resolved Hide resolved
webviz_subsurface/plugins/_well_analysis/_views/_well_control.py Outdated Show resolved Hide resolved
webviz_subsurface/plugins/_well_analysis/_views/_well_overview.py Outdated Show resolved Hide resolved
webviz_subsurface/plugins/_well_analysis/_views/_well_overview.py Outdated Show resolved Hide resolved
@anders-kiaer anders-kiaer marked this pull request as ready for review August 8, 2022 07:22
@lindjoha lindjoha self-requested a review August 8, 2022 11:13
@lindjoha lindjoha self-assigned this Aug 9, 2022
@lindjoha lindjoha force-pushed the WellAnalysis_trail branch from b930eef to 792d2e2 Compare August 16, 2022 09:14
@lindjoha lindjoha force-pushed the WellAnalysis_trail branch from 792d2e2 to e020418 Compare August 26, 2022 12:03
anders-kiaer
anders-kiaer approved these changes Sep 15, 2022
View reviewed changes
Copy link
Collaborator

@anders-kiaer anders-kiaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🚀 Just a couple of super small suggestions from me. LGTM.

webviz_subsurface/plugins/_well_analysis/_plugin.py Outdated Show resolved Hide resolved
webviz_subsurface/plugins/_well_analysis/_plugin.py Outdated Show resolved Hide resolved
Eirik Sundby Håland (OG SUB RPE) and others added 20 commits September 15, 2022 09:21
reformatting
271f17e
Various small improvements
7abdf6e
Fixed bug and put settings in view files
21e4fbb
pylint fix
d51c83a
Removed most of the stores and some other code cleanup
826fdf2
bugfix
375942f
Many improvements
173a19f
More improvements
4f5916b
Refactored the code according to the WLF best practice
43d34f5
Removed well attributes filter, and more code improvements
a0f702f
Refactored code again, putting figures in view utils folders
fb1ee77
Introduced a view element and got rid of the last store
043aecc
Simplified tour_steps and removed some imports from init files
7ffc995
Added label to layout options checkbox
6482b04
Implemented a view element also for the well control view
0ae82e6
Added changelog
4a761cc
Removed the error layout
c9bf2cd
Implemented StrEnum and callback_typecheck
78d42c2
Fixed bug in callback so that only layout is updated if data is uncha…
317a349 
…nged
Implemented new callback_typecheck that handles Optional type
bc8353c
@lindjoha lindjoha merged commit 6d093ef into equinor:master Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JinCheng2022 JinCheng2022 JinCheng2022 left review comments

@anders-kiaer anders-kiaer anders-kiaer approved these changes

@lindjoha lindjoha Awaiting requested review from lindjoha

@rubenthoms rubenthoms Awaiting requested review from rubenthoms

Assignees

@lindjoha lindjoha

Labels
WLF
Projects
Webviz
Status: Done 🏁
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

WellAnalysis to WLF
4 participants
@EirikPeirik @anders-kiaer @lindjoha @JinCheng2022