Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add color tables to MapViewer #1037

Merged
merged 1 commit into from
May 29, 2022
Merged

Add color tables to MapViewer #1037

merged 1 commit into from
May 29, 2022

Conversation

HansKallekleiv
Copy link
Collaborator

Insert a description of your pull request (PR) here, and check off the boxes below when they are done.

Contributor checklist

  • 🎉 This PR closes #ISSUE_NUMBER.
  • 📜 I have broken down my PR into the following tasks:
    • Task 1
    • Task 2
  • 🤖 I have added tests, or extended existing tests, to cover any new features or bugs fixed in this PR.
  • 📖 I have considered adding a new entry in CHANGELOG.md, and added it if should be communicated there.

@HansKallekleiv HansKallekleiv force-pushed the add-colortables branch 2 times, most recently from 1aa99eb to fe7e8c2 Compare May 24, 2022 08:53
anders-kiaer
anders-kiaer requested changes May 25, 2022
View reviewed changes
Copy link
Collaborator

@anders-kiaer anders-kiaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Some small suggestions to consider only, then this is ready for 🚢

CHANGELOG.md Outdated Show resolved Hide resolved
webviz_subsurface/plugins/_map_viewer_fmu/color_tables.py Show resolved Hide resolved
webviz_subsurface/plugins/_map_viewer_fmu/map_viewer_fmu.py Show resolved Hide resolved
webviz_subsurface/plugins/_map_viewer_fmu/map_viewer_fmu.py Outdated Show resolved Hide resolved
@anders-kiaer anders-kiaer changed the title Add colortables to MapViewer Add color tables to MapViewer May 25, 2022
@anders-kiaer anders-kiaer added the next release 🚢 To be included in next release label May 27, 2022
@anders-kiaer anders-kiaer merged commit 5026607 into equinor:master May 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anders-kiaer anders-kiaer anders-kiaer approved these changes

@tnatt tnatt Awaiting requested review from tnatt

Assignees

@HansKallekleiv HansKallekleiv

Labels
next release 🚢 To be included in next release
Projects
Webviz
Status: Done 🏁
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HansKallekleiv @anders-kiaer