-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New data provider in ParameterResponseCorrelation
#1030
Merged
lindjoha
merged 13 commits into
equinor:master
from
lindjoha:parameter_response_provider
May 25, 2022
Merged
New data provider in ParameterResponseCorrelation
#1030
lindjoha
merged 13 commits into
equinor:master
from
lindjoha:parameter_response_provider
May 25, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
02e13b2
to
1572962
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Minor comment only.
Should add a changelog entry perhaps as this is a somewhat big change for ParameterResponseCorrelation
?
webviz_subsurface/_providers/ensemble_summary_provider/utils.py
Outdated
Show resolved
Hide resolved
dff9df0
to
e3305e9
Compare
e3305e9
to
8d5bb96
Compare
anders-kiaer
approved these changes
May 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work 👏 LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the new summary data provider i
ParameterResponseCorrelation
.I also needed to make a general function that matches column_keys with * as wildcard. I have put it in EnsembleSummaryProvider, but we can discuss where it should be.
Contributor checklist
ParameterResponseCorrelation
in Move away from.UNSMRY
to.arrow
provider #858CHANGELOG.md
, and added it if should be communicated there.