Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New data provider in ParameterResponseCorrelation #1030

Merged
merged 13 commits into from
May 25, 2022

Conversation

lindjoha
Copy link
Collaborator

@lindjoha lindjoha commented May 15, 2022

This PR implements the new summary data provider i ParameterResponseCorrelation.

I also needed to make a general function that matches column_keys with * as wildcard. I have put it in EnsembleSummaryProvider, but we can discuss where it should be.

Contributor checklist

  • 🎉 This PR closes ParameterResponseCorrelation in Move away from .UNSMRY to .arrow provider #858
  • 📜 I have broken down my PR into the following tasks:
    • New data provider
    • General function that matches column_keys with wild cards
  • 🤖 I have added tests, or extended existing tests, to cover any new features or bugs fixed in this PR.
  • 📖 I have considered adding a new entry in CHANGELOG.md, and added it if should be communicated there.

@lindjoha lindjoha self-assigned this May 15, 2022
@lindjoha lindjoha force-pushed the parameter_response_provider branch from 02e13b2 to 1572962 Compare May 20, 2022 06:07
Copy link
Collaborator

@anders-kiaer anders-kiaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Minor comment only.

Should add a changelog entry perhaps as this is a somewhat big change for ParameterResponseCorrelation?

@anders-kiaer anders-kiaer added the next release 🚢 To be included in next release label May 23, 2022
@lindjoha lindjoha force-pushed the parameter_response_provider branch from dff9df0 to e3305e9 Compare May 23, 2022 06:58
@lindjoha lindjoha force-pushed the parameter_response_provider branch from e3305e9 to 8d5bb96 Compare May 24, 2022 17:19
Copy link
Collaborator

@anders-kiaer anders-kiaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work 👏 LGTM

@lindjoha lindjoha merged commit 6c56649 into equinor:master May 25, 2022
@lindjoha lindjoha deleted the parameter_response_provider branch May 25, 2022 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next release 🚢 To be included in next release
Projects
Status: Done 🏁
Development

Successfully merging this pull request may close these issues.

2 participants