Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various bugfixes #1014

Merged
merged 3 commits into from
Apr 28, 2022
Merged

Various bugfixes #1014

merged 3 commits into from
Apr 28, 2022

Conversation

tnatt
Copy link
Collaborator

@tnatt tnatt commented Apr 27, 2022

PR with bugfixes:

  1. ParameterResponseCorrelation and BhpQc: add step=1 to slider to prevent bug due to float numbers
  2. SwatinitQC: don't show contacts if the contacts are shallower than the dataset (dummy contacts)
  3. VolumericAnalysis: only include numeric columns as volumetric responses
  4. VolumericAnalysis: remove rows with Totals" before summing volumes over disjoint sets
  5. VolumericAnalysis: prevent rows beeing removed if the License is called "Totals" ("Totals" should only be removed from Zone/Region/Facies)

@tnatt tnatt added the bug 🐛 Something isn't working label Apr 27, 2022
@tnatt tnatt requested a review from anders-kiaer April 27, 2022 09:11
@tnatt tnatt self-assigned this Apr 27, 2022
@anders-kiaer anders-kiaer added the next release 🚢 To be included in next release label Apr 27, 2022
Copy link
Collaborator

@anders-kiaer anders-kiaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment only - otherwise LGTM 🐛

@tnatt tnatt force-pushed the various_bugfixes branch from 9c6c3d2 to a8a46c0 Compare April 28, 2022 11:35
@tnatt tnatt merged commit 4cce8cd into equinor:master Apr 28, 2022
VincentNevermore pushed a commit to VincentNevermore/webviz-subsurface that referenced this pull request Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working next release 🚢 To be included in next release
Projects
Status: Done 🏁
Development

Successfully merging this pull request may close these issues.

2 participants