Toggling history trace in legend only works on first vector in ReservoirSimulationTimeSeries

[asnyv]

Describe the bug
Toggling the "History" in the legend only removes the "History" trace from the first vector if multiple vectors are plotted.

How to reproduce
Steps to reproduce the behavior:

1. Go to Simulation time series
2. Click on e.g. vectors FOPR, FGPR, FGPT
3. Toggle history be clicking at "History" in the legend
4. See that the black line only disappears in the uppermost subplot

Expected behavior
History trace should disappear in all subplots

Screenshots
Not toggled in legend, all visible (as it is supposed to be):

Toggled, still two history traces visible:

Additional context
Can most likely be fixed by adding a constant legendgroup to add_history_trace

webviz-subsurface/webviz_subsurface/plugins/_reservoir_simulation_timeseries.py

Lines 1099 to 1108 in 5503310

	return {
	"line": {"shape": line_shape},
	"x": df["DATE"],
	"y": df[vector],
	"hovertext": "History",
	"hoverinfo": "y+x+text",
	"name": "History",
	"marker": {"color": "black"},
	"showlegend": True,
	}

[robpoll]

I'd like to work on this issue.

[asnyv]

I'd like to work on this issue.

Sorry @robpoll, as I had already identified the issue, and it was only one line to do it, I had already made the fix. But there are many other issues in the list 😉 😄

[robpoll]

Alright @asnyv. This project got my interest, so I'd like to contribute somehow. I'm new to this open source contributing, so something simple would be great for the beginning. What do you reckon?

[asnyv]

Not sure how familiar you are with subsurface simulation data @robpoll? If you are not, maybe it is a good idea to start in the more generic library webviz-config? webviz-subsurface is an extension of this directed towards ensemble based reservoir simulation applications in the petroleum industry.

[robpoll]

Unfortunately, I'm not familiar with that @asnyv. I'll have a look on issues in webviz-config, but I think without some guidance I wouldn't be able to really contribute and I'll have to look elsewhere.

[asnyv]

@robpoll Best place to start is probably to filter on "good first issues" in webviz-config.
They are a bit varied, several of them are focused on the framework itself, but if you prefer to work more towards the plugin side (similar to webviz-subsurface, which is mainly a collection of plugins for webviz-config), you can look at e.g. this: equinor/webviz-config#297 And if you have questions, comment in the relevant issue and we'll try to give the relevant input there 😄

[robpoll]

Alright, I'll have a look on that one. Thank you @asnyv. Will do so!

[robpoll]

After following the steps in readme.md, after running the command webviz it says: zsh: command not found: webviz

…

On Wed, Sep 30, 2020 at 3:14 PM Asgeir Nyvoll ***@***.***> wrote: @robpoll <https://github.com/robpoll> Best place to start is probably to filter on "good first issues" in webviz-config <https://github.com/equinor/webviz-config/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22> . They are a bit varied, several of them are focused on the framework itself, but if you prefer to work more towards the plugin side (similar to webviz-subsurface, which is mainly a collection of plugins for webviz-config), you can look at e.g. this: equinor/webviz-config#297 <equinor/webviz-config#297> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#458 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AI5WXIMEV6IB5Y6HHBD4HYLSIMVKTANCNFSM4R6XPE3A> .

[asnyv]

@robpoll could you say exactly which steps you have made?

[robpoll]

git clone [email protected]:equinor/webviz-config.git

cd ./webviz-config

npm ci --ignore-scripts && npm run postinstall

pip install -e .

Instead of pip I used pip3.

[asnyv]

@robpoll Could you try "pip freeze" (or in your case "pip3 freeze") to see if webviz-config is in your list of installed packages?

[anders-kiaer]

I would also try rehashing your terminal window (or simply opening a new terminal with the Python environment you installed it in activated). This could typically happen in general in already open terminal windows when what is available on your $PATHs changes (which it does when you install a new Python console entrypoint).

[robpoll]

Well, I have here webviz-core-components==0.1.0
and I have a strange entry, which is

-e [email protected]:equinor/webviz-config.git@a lot of characters#egg=webviz_config

[anders-kiaer]

and I have a strange entry, which is -e [email protected]:equinor/webviz-config.git@a lot of characters#egg=webviz_config

That is expected (when you install from unreleased source code, and not pip install webviz-config... more details here https://github.com/pypa/setuptools_scm).

[robpoll]

Thanks @anders-kiaer @asnyv, I have created another venv and installed once again. Now it works!