Skip to content

Commit

Permalink
Support Pandas 1.2.0. Remove Pandas 0.24 from CI
Browse files Browse the repository at this point in the history
  • Loading branch information
Hans Kallekleiv authored and HansKallekleiv committed Jan 6, 2021
1 parent 493b955 commit 5b5f2a5
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 13 deletions.
15 changes: 4 additions & 11 deletions .github/workflows/subsurface.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,6 @@ jobs:
fail-fast: false
matrix:
python-version: ['3.6', '3.7', '3.8']
pandas-version: ['0.24.2', '1.*'] # Necessary as long as RHEL6 is used internally
exclude:
# Skip Python 3.8 and Pandas 0.24.2 combination due to missing 3.8 wheel for that specific pandas version
- python-version: '3.8'
pandas-version: '0.24.2'

steps:

Expand All @@ -54,7 +49,6 @@ jobs:
if [[ $(pip freeze) ]]; then
pip freeze | grep -vw "pip" | xargs pip uninstall -y
fi
pip install 'pandas==${{ matrix.pandas-version }}'
pip install .
# There are dependencies which we can't have in setup.py yet due to limitations in internal deployment system ("komodo"):
pip install libecl ecl2df opm
Expand All @@ -71,7 +65,6 @@ jobs:
run: pip freeze

- name: 🕵️ Check code style & linting
if: matrix.pandas-version == '1.*'
run: |
black --check webviz_subsurface tests setup.py
pylint webviz_subsurface tests setup.py
Expand Down Expand Up @@ -106,21 +99,21 @@ jobs:
popd
- name: 🐳 Update Docker Hub example image
if: github.event_name != 'schedule' && github.ref == 'refs/heads/master' && matrix.python-version == '3.6' && matrix.pandas-version == '1.*'
if: github.event_name != 'schedule' && github.ref == 'refs/heads/master' && matrix.python-version == '3.6'
run: |
echo ${{ secrets.dockerhub_webviz_token }} | docker login --username webviz --password-stdin
docker push webviz/example_subsurface_image:equinor-theme
- name: 🐳 Update review/test Docker example image
if: github.ref != 'refs/heads/master' && contains(github.event.head_commit.message, '[deploy test]') && matrix.python-version == '3.6' && matrix.pandas-version == '1.*'
if: github.ref != 'refs/heads/master' && contains(github.event.head_commit.message, '[deploy test]') && matrix.python-version == '3.6'
run: |
docker tag webviz/example_subsurface_image:equinor-theme ${{ secrets.review_docker_registry_url }}/${{ secrets.review_container_name }}
echo ${{ secrets.review_docker_registry_token }} | docker login ${{ secrets.review_docker_registry_url }} --username ${{ secrets.review_docker_registry_username }} --password-stdin
docker push ${{ secrets.review_docker_registry_url }}/${{ secrets.review_container_name }}
- name: 🚢 Build and deploy Python package
if: github.event_name == 'release' && matrix.python-version == '3.6' && matrix.pandas-version == '1.*'
if: github.event_name == 'release' && matrix.python-version == '3.6'
env:
TWINE_USERNAME: __token__
TWINE_PASSWORD: ${{ secrets.pypi_webviz_token }}
Expand All @@ -130,7 +123,7 @@ jobs:
twine upload dist/*
- name: 📚 Update GitHub pages
if: github.event_name == 'release' && matrix.python-version == '3.6' && matrix.pandas-version == '1.*'
if: github.event_name == 'release' && matrix.python-version == '3.6'
run: |
cp -R ./docs_build ../docs_build
Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@
# "opm>=2020.10.1; sys_platform=='linux'",
"pandas>=0.24",
"pillow>=6.1",
"pyscal>=0.4.1",
"pyscal>=0.7.2",
"scipy>=1.2",
"statsmodels>=0.12.1", # indirect dependency through https://plotly.com/python/linear-fits/
"webviz-config>=0.0.55",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1416,7 +1416,7 @@ def get_fip_array_nodes(fip: str, smry_cols: list) -> List[str]:
}
)
)
return [str(i) for i in sorted_int_list]
return sorted_int_list


@webvizstore
Expand Down

0 comments on commit 5b5f2a5

Please sign in to comment.