fix: "Incorrect 2D axes rendering with vertical scaling #1957" #1971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilscb
added
bug
w1nklr
reviewed
Mar 19, 2024
| @@ -1,20 +1,18 @@ | |||
| export default `\ | |||
| #version 300 es | |||
| #define SHADER_NAME graph-layer-axis-vertex-shader | |||
| #define SHADER_NAME axes2d-layer-vertex-shader //graph-layer-axis-vertex-shader | |||
| @@ -1,6 +1,6 @@ | |||
| export default `\ | |||
| #version 300 es | |||
| #define SHADER_NAME graph-layer-fragment-shader | |||
| #define SHADER_NAME graph-layer-fragment-shader | |||
There was a problem hiding this comment.
If you rename the vertex shader, please update this one accordingly...
w1nklr
reviewed
Mar 19, 2024
typescript/packages/subsurface-viewer/src/layers/axes2d/label-vertex.glsl.js
Show resolved
Hide resolved
hkfb
reviewed
Mar 20, 2024
typescript/packages/subsurface-viewer/src/layers/axes2d/axes2DLayer.ts
Outdated
Show resolved
Hide resolved
w1nklr
pushed a commit
to w1nklr/webviz-subsurface-components
that referenced
this pull request
Mar 20, 2024
## [0.5.8](https://github.com/equinor/webviz-subsurface-components/compare/[email protected]@0.5.8) (2024-03-12) ### Bug Fixes * bump ajv from 7.2.1 to 8.12.0 in /typescript ([equinor#1947](equinor#1947)) ([af95651](equinor@af95651)), closes [equinor#2190](equinor#2190) [equinor#2191](equinor#2191) [equinor#2158](equinor#2158) [equinor#2194](equinor#2194) [equinor#2192](equinor#2192) [ajv-validator/ajv#1840](ajv-validator/ajv#1840) [equinor#1840](equinor#1840) [equinor#1901](equinor#1901) [equinor#1922](equinor#1922) [equinor#1862](equinor#1862) [equinor#1861](equinor#1861) [equinor#1815](equinor#1815) [ajv-validator/ajv-keywords#220](ajv-validator/ajv-keywords#220) [equinor#1819](equinor#1819) [equinor#1725](equinor#1725) [equinor#1757](equinor#1757) [equinor#2195](equinor#2195) [equinor#1971](equinor#1971) [equinor#2194](equinor#2194) [equinor#2184](equinor#2184) [equinor#2193](equinor#2193) [equinor#2183](equinor#2183) [equinor#2158](equinor#2158) [equinor#2160](equinor#2160) [equinor#1935](equinor#1935) [equinor#2192](equinor#2192) [equinor#1949](equinor#1949) [equinor#2191](equinor#2191)
w1nklr
pushed a commit
to w1nklr/webviz-subsurface-components
that referenced
this pull request
Mar 20, 2024
## [1.2.8](https://github.com/equinor/webviz-subsurface-components/compare/[email protected]@1.2.8) (2024-03-12) ### Bug Fixes * bump ajv from 7.2.1 to 8.12.0 in /typescript ([equinor#1947](equinor#1947)) ([af95651](equinor@af95651)), closes [equinor#2190](equinor#2190) [equinor#2191](equinor#2191) [equinor#2158](equinor#2158) [equinor#2194](equinor#2194) [equinor#2192](equinor#2192) [ajv-validator/ajv#1840](ajv-validator/ajv#1840) [equinor#1840](equinor#1840) [equinor#1901](equinor#1901) [equinor#1922](equinor#1922) [equinor#1862](equinor#1862) [equinor#1861](equinor#1861) [equinor#1815](equinor#1815) [ajv-validator/ajv-keywords#220](ajv-validator/ajv-keywords#220) [equinor#1819](equinor#1819) [equinor#1725](equinor#1725) [equinor#1757](equinor#1757) [equinor#2195](equinor#2195) [equinor#1971](equinor#1971) [equinor#2194](equinor#2194) [equinor#2184](equinor#2184) [equinor#2193](equinor#2193) [equinor#2183](equinor#2183) [equinor#2158](equinor#2158) [equinor#2160](equinor#2160) [equinor#1935](equinor#1935) [equinor#2192](equinor#2192) [equinor#1949](equinor#1949) [equinor#2191](equinor#2191)
w1nklr
pushed a commit
to w1nklr/webviz-subsurface-components
that referenced
this pull request
Mar 20, 2024
## [0.20.1](https://github.com/equinor/webviz-subsurface-components/compare/[email protected]@0.20.1) (2024-03-12) ### Bug Fixes * bump ajv from 7.2.1 to 8.12.0 in /typescript ([equinor#1947](equinor#1947)) ([af95651](equinor@af95651)), closes [equinor#2190](equinor#2190) [equinor#2191](equinor#2191) [equinor#2158](equinor#2158) [equinor#2194](equinor#2194) [equinor#2192](equinor#2192) [ajv-validator/ajv#1840](ajv-validator/ajv#1840) [equinor#1840](equinor#1840) [equinor#1901](equinor#1901) [equinor#1922](equinor#1922) [equinor#1862](equinor#1862) [equinor#1861](equinor#1861) [equinor#1815](equinor#1815) [ajv-validator/ajv-keywords#220](ajv-validator/ajv-keywords#220) [equinor#1819](equinor#1819) [equinor#1725](equinor#1725) [equinor#1757](equinor#1757) [equinor#2195](equinor#2195) [equinor#1971](equinor#1971) [equinor#2194](equinor#2194) [equinor#2184](equinor#2184) [equinor#2193](equinor#2193) [equinor#2183](equinor#2183) [equinor#2158](equinor#2158) [equinor#2160](equinor#2160) [equinor#1935](equinor#1935) [equinor#2192](equinor#2192) [equinor#1949](equinor#1949) [equinor#2191](equinor#2191)
w1nklr
pushed a commit
to w1nklr/webviz-subsurface-components
that referenced
this pull request
Mar 20, 2024
## [1.1.8](https://github.com/equinor/webviz-subsurface-components/compare/[email protected]@1.1.8) (2024-03-12) ### Bug Fixes * bump ajv from 7.2.1 to 8.12.0 in /typescript ([equinor#1947](equinor#1947)) ([af95651](equinor@af95651)), closes [equinor#2190](equinor#2190) [equinor#2191](equinor#2191) [equinor#2158](equinor#2158) [equinor#2194](equinor#2194) [equinor#2192](equinor#2192) [ajv-validator/ajv#1840](ajv-validator/ajv#1840) [equinor#1840](equinor#1840) [equinor#1901](equinor#1901) [equinor#1922](equinor#1922) [equinor#1862](equinor#1862) [equinor#1861](equinor#1861) [equinor#1815](equinor#1815) [ajv-validator/ajv-keywords#220](ajv-validator/ajv-keywords#220) [equinor#1819](equinor#1819) [equinor#1725](equinor#1725) [equinor#1757](equinor#1757) [equinor#2195](equinor#2195) [equinor#1971](equinor#1971) [equinor#2194](equinor#2194) [equinor#2184](equinor#2184) [equinor#2193](equinor#2193) [equinor#2183](equinor#2183) [equinor#2158](equinor#2158) [equinor#2160](equinor#2160) [equinor#1935](equinor#1935) [equinor#2192](equinor#2192) [equinor#1949](equinor#1949) [equinor#2191](equinor#2191)
w1nklr
pushed a commit
to w1nklr/webviz-subsurface-components
that referenced
this pull request
Mar 20, 2024
## [1.5.1](https://github.com/equinor/webviz-subsurface-components/compare/[email protected]@1.5.1) (2024-03-12) ### Bug Fixes * bump ajv from 7.2.1 to 8.12.0 in /typescript ([equinor#1947](equinor#1947)) ([af95651](equinor@af95651)), closes [equinor#2190](equinor#2190) [equinor#2191](equinor#2191) [equinor#2158](equinor#2158) [equinor#2194](equinor#2194) [equinor#2192](equinor#2192) [ajv-validator/ajv#1840](ajv-validator/ajv#1840) [equinor#1840](equinor#1840) [equinor#1901](equinor#1901) [equinor#1922](equinor#1922) [equinor#1862](equinor#1862) [equinor#1861](equinor#1861) [equinor#1815](equinor#1815) [ajv-validator/ajv-keywords#220](ajv-validator/ajv-keywords#220) [equinor#1819](equinor#1819) [equinor#1725](equinor#1725) [equinor#1757](equinor#1757) [equinor#2195](equinor#2195) [equinor#1971](equinor#1971) [equinor#2194](equinor#2194) [equinor#2184](equinor#2184) [equinor#2193](equinor#2193) [equinor#2183](equinor#2183) [equinor#2158](equinor#2158) [equinor#2160](equinor#2160) [equinor#1935](equinor#1935) [equinor#2192](equinor#2192) [equinor#1949](equinor#1949) [equinor#2191](equinor#2191)
hkfb
approved these changes
Mar 21, 2024
|
🎉 This issue has been resolved in version [email protected] 🎉 The release is available on GitHub release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Axes2DLayer now works with vertical scaling
-also some refactoring of this layer.