Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add a callback function to display the selected wells #1333

Merged
merged 16 commits into from
Dec 7, 2022
Merged

add a callback function to display the selected wells #1333

merged 16 commits into from
Dec 7, 2022

Conversation

VincentNevermore
Copy link
Contributor

@VincentNevermore VincentNevermore commented Dec 1, 2022 •
edited
Loading

image

@VincentNevermore VincentNevermore requested a review from hkfb December 1, 2022 11:22
@codecov-commenter
Copy link

codecov-commenter commented Dec 1, 2022 •
edited
Loading

Codecov Report

Merging #1333 (e3c3444) into master (78bf0b0) will not change coverage.
The diff coverage is 50.00%.

@@           Coverage Diff           @@
##           master    #1333   +/-   ##
=======================================
  Coverage   35.38%   35.38%           
=======================================
  Files         156      156           
  Lines        8501     8501           
  Branches     2271     2259   -12     
=======================================
  Hits         3008     3008           
  Misses       5460     5460           
  Partials       33       33
Impacted Files Coverage Δ
.../components/DeckGLMap/layers/layersDefaultProps.ts 100.00% <ø> (ø)
...Map/layers/BoxSelectionLayer/boxSelectionLayer.tsx 6.45% <50.00%> (ø)
react/src/lib/components/DeckGLMap/DeckGLMap.tsx 82.35% <0.00%> (ø)
...rc/lib/components/DeckGLMap/layers/map/mapLayer.ts 1.73% <0.00%> (ø)
...lib/components/DeckGLMap/components/ViewFooter.tsx 100.00% <0.00%> (ø)
...ct/src/lib/components/DeckGLMap/components/Map.tsx 49.54% <0.00%> (+0.33%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@VincentNevermore VincentNevermore requested a review from hkfb December 2, 2022 09:17
@VincentNevermore VincentNevermore self-assigned this Dec 5, 2022
@VincentNevermore VincentNevermore requested a review from hkfb December 5, 2022 17:29
@VincentNevermore VincentNevermore requested a review from hkfb December 6, 2022 09:49
hkfb
hkfb requested changes Dec 6, 2022
View reviewed changes
react/src/lib/components/DeckGLMap/layers/BoxSelectionLayer/boxSelectionLayer.tsx Outdated Show resolved Hide resolved
react/src/lib/components/DeckGLMap/layers/BoxSelectionLayer/boxSelectionLayer.stories.tsx Outdated
<DeckGLMap
id={"DeckGL-Map"}
{...lassoArgsWithSelectedWellsDataCallback}
legend={{ visible: false }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The legend prop has been deprecated.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The legend prop has been deprecated.

react/src/lib/components/DeckGLMap/layers/BoxSelectionLayer/boxSelectionLayer.stories.tsx Outdated Show resolved Hide resolved
@hkfb hkfb mentioned this pull request Dec 7, 2022
Closed
@VincentNevermore VincentNevermore requested a review from hkfb December 7, 2022 11:04
hkfb
hkfb requested changes Dec 7, 2022
View reviewed changes
react/src/lib/components/DeckGLMap/layers/BoxSelectionLayer/boxSelectionLayer.stories.tsx Outdated
<DeckGLMap
id={"DeckGL-Map"}
{...lassoArgsWithSelectedWellsDataCallback}
legend={{ visible: false }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The legend prop has been deprecated.

@VincentNevermore VincentNevermore requested a review from hkfb December 7, 2022 11:51
@hkfb hkfb added enhancement New feature or request AspenTech Task owned by AspenTech map-component Issues related to the map component. labels Dec 7, 2022
@hkfb
Copy link
Collaborator

hkfb commented Dec 7, 2022

Please attach any issue ids that this PR solves.

@VincentNevermore VincentNevermore merged commit d4790d8 into equinor:master Dec 7, 2022
@VincentNevermore VincentNevermore linked an issue Dec 7, 2022 that may be closed by this pull request
Selecting multiple well trajectories #531
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hkfb hkfb hkfb approved these changes

Assignees

@VincentNevermore VincentNevermore

Labels
AspenTech Task owned by AspenTech enhancement New feature or request map-component Issues related to the map component.
Projects
Webviz
Status: Done 🏁
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Selecting multiple well trajectories
3 participants
@VincentNevermore @codecov-commenter @hkfb