Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webviz testing fixture #615

Merged
merged 3 commits into from
Aug 29, 2022
Merged

Conversation

HansKallekleiv
Copy link
Collaborator

Insert a description of your pull request (PR) here, and check off the boxes below when they are done.


Contributor checklist

  • 🎉 This PR closes #ISSUE_NUMBER.
  • 📜 I have broken down my PR into the following tasks:
    • Task 1
    • Task 2
  • 🤖 I have added tests, or extended existing tests, to cover any new features or bugs fixed in this PR.
  • 📖 I have considered adding a new entry in CHANGELOG.md, and added it if should be communicated there.

Copy link
Collaborator

@anders-kiaer anders-kiaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - some small comments.

tests/test_example_wlf_plugin.py Outdated Show resolved Hide resolved
tests/test_example_wlf_plugin.py Outdated Show resolved Hide resolved
webviz_config/testing/_composite.py Outdated Show resolved Hide resolved
webviz_config/testing/_plugin.py Outdated Show resolved Hide resolved
@HansKallekleiv HansKallekleiv marked this pull request as ready for review August 18, 2022 11:24
@HansKallekleiv HansKallekleiv requested a review from asnyv as a code owner August 18, 2022 11:24
Copy link
Collaborator

@rubenthoms rubenthoms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍 Some comments, see below.

webviz_config/testing/_composite.py Outdated Show resolved Hide resolved
webviz_config/testing/_composite.py Outdated Show resolved Hide resolved
webviz_config/testing/_webviz_ids.py Show resolved Hide resolved
Copy link
Collaborator

@rubenthoms rubenthoms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants