Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy mean, stdev and estimated facies probabilities to one realization of the geogrid #749

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

oddvarlia
Copy link
Collaborator

@oddvarlia oddvarlia commented Oct 7, 2024

The purpose of the new option -g is to copy the results (mean, stdev, facies prob estimates) from ertbox grid which is fixed and only works as a "container" for the values into a single realization (realization 0) of the geogrid. The argument for this is to be able to visualize the results together with blocked well facies log and petrophysical logs.

There are several things to notice here:

  • Since the result is copied into a single grid realization, only the results for grid cells for that grid realization will be possible to see. But if we assume that the grid realization is based on a structural model conditioned to the wells, it should be possible to inspect the results along the well paths in the single realization.
  • The statistical results are based on the main assumption that field values (facies, petrophysical values) belonging to the same grid cell index belongs to the same probability distribution regardless of the whether the geometry of the geogrid varies laterally or vertically from realization to realization.
  • Since number of active grid cells vary from realization to realization, the confidence of the estimates of mean, stdev, facies probabilities will vary from grid cell to grid cell depending on how many realizations have the given grid cell as an active grid cell. Hence, for top or base conform grids this will vary a lot at the base or top of the zone. For grids with stair case faults, also along these faults the active grid cells will vary a lot and the number of realization for each grid cell index will vary from grid cell to grid cell around these faults.

@codecov-commenter
Copy link

codecov-commenter commented Oct 7, 2024

Codecov Report

Attention: Patch coverage is 92.40506% with 6 lines in your changes missing coverage. Please review.

Project coverage is 85.91%. Comparing base (afef91f) to head (622524f).

Files with missing lines Patch % Lines
src/subscript/field_statistics/field_statistics.py 92.40% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #749      +/-   ##
==========================================
+ Coverage   85.85%   85.91%   +0.06%     
==========================================
  Files          52       52              
  Lines        7245     7307      +62     
==========================================
+ Hits         6220     6278      +58     
- Misses       1025     1029       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oddvarlia oddvarlia requested a review from jcrivenaes October 8, 2024 05:54
@oddvarlia oddvarlia force-pushed the update_generated_rms_script branch from 6dab400 to 7038ba8 Compare October 8, 2024 06:00
Copy link
Contributor

@jcrivenaes jcrivenaes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments to consider, otherwise LGTM

@oddvarlia oddvarlia force-pushed the update_generated_rms_script branch from 7038ba8 to 82ac30a Compare October 8, 2024 14:08
Copy link
Collaborator

@alifbe alifbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

in realization 0 on scratch for iteration 0 and final iteration.

Updated documentation

 Updated doc for ERT
@oddvarlia oddvarlia force-pushed the update_generated_rms_script branch from 82ac30a to 622524f Compare October 9, 2024 12:11
@oddvarlia oddvarlia merged commit 86af7ec into equinor:main Oct 9, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants