Fix test_sunsch #700
Merged
Fix test_sunsch #700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alifbe
commented
May 13, 2024
| assert "A-007" in str(sch) | ||
| assert "<ORAT>" in str(sch) | ||
| # (this error is let through sunsch) | ||
|
|
||
| # Let the date be undefined. |
There was a problem hiding this comment.
opm doesn't accept argument anymore. Previously, it was taken as UDQ, but now it's flagged as invalid UDQ (with the new name validation)
alifbe
commented
May 13, 2024
| @@ -776,7 +759,7 @@ def test_weltarg_uda(tmp_path): | |||
| """WELTARG supports UDA from opm-common 2020.10""" | |||
| os.chdir(tmp_path) | |||
| weltargkeyword = """WELTARG | |||
| 'OP-1' ORAT SOMEUDA / | |||
| 'OP-1' ORAT WU_VALUE / | |||
There was a problem hiding this comment.
Replace SOMEUDA with WU_VALUE to meet the valid UDQ name criteria.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest
opmhas implemented check for valid UDQ based on its name. This create issue withsunschtest.OPM/opm-common#3842
This PR fixes the test that failed due to the changes.