Update csv_stack test for pandas >= 2.1 #653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pandas 2 preserves the column ordering now, presumably as a bug fix, so have adapted to the test to not expect the old column ordering.
mferrera
force-pushed
the
fix-pandas-2
branch
from
56c836f to
318e8aa
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #653 +/- ##
=======================================
Coverage 86.11% 86.11%
=======================================
Files 50 50
Lines 7058 7058
=======================================
Hits 6078 6078
Misses 980 980 ☔ View full report in Codecov by Sentry. |
mferrera
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #634
Pandas 2 preserves the column ordering now, presumably as a bug fix, so have adapted to the test to not expect the old column ordering. The ordering will remain different from Python 3.8 because this change occurred between Pandas 2.0.3 and later versions (2.1, 2.2). I could not find the exact Pandas issue.