Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove protobuf as a dependency #604

Merged
merged 1 commit into from
Sep 18, 2023
Merged

Conversation

mferrera
Copy link
Collaborator

It is pulled in through the dependency chain but is not a first class dependency.

Resolves #598

It is pulled in through the dependency chain but is not a first
class dependency.
@codecov-commenter
Copy link

Codecov Report

Merging #604 (e71b6b0) into main (ee980ef) will not change coverage.
The diff coverage is n/a.

❗ Current head e71b6b0 differs from pull request most recent head 9afc4c5. Consider uploading reports for the commit 9afc4c5 to get more accurate results

@@           Coverage Diff           @@
##             main     #604   +/-   ##
=======================================
  Coverage   84.71%   84.71%           
=======================================
  Files          52       52           
  Lines        7510     7510           
=======================================
  Hits         6362     6362           
  Misses       1148     1148           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mferrera mferrera requested a review from alifbe September 18, 2023 07:52
Copy link
Collaborator

@alifbe alifbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mferrera mferrera merged commit 2770284 into equinor:main Sep 18, 2023
@mferrera mferrera deleted the prune-deps branch September 18, 2023 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Double-check dependencies
3 participants