-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
casegen_upcars
Add more detail documentation
#602
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Highlighted some very minor nitpicks, but great documentation addition 😄👍
docs/scripts/casegen_upcars.rst
Outdated
in complex carbonate reservoirs) project. | ||
|
||
Output from casegen_upcars is in the form of Eclipse simulation models. These | ||
models can be run to investigate impact of changing geological properties on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick:
investigate the impact
docs/scripts/casegen_upcars.rst
Outdated
The script can generate various types of grid structure (tilting, dome, and | ||
hull) amd throws. The input file is in yaml format. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick, maybe?
grid structure_s_
also
s/amd/and
Codecov Report
@@ Coverage Diff @@
## main #602 +/- ##
=======================================
Coverage 84.71% 84.71%
=======================================
Files 52 52
Lines 7510 7510
=======================================
Hits 6362 6362
Misses 1148 1148
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Improve documentation page for
casegen_upcars