Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

casegen_upcars Add more detail documentation #602

Merged
merged 2 commits into from
Sep 19, 2023
Merged

casegen_upcars Add more detail documentation #602

merged 2 commits into from
Sep 19, 2023

Conversation

alifbe
Copy link
Collaborator

@alifbe alifbe commented Sep 14, 2023

Improve documentation page for casegen_upcars

@alifbe alifbe requested review from mferrera and rnyb September 14, 2023 12:48
Copy link
Collaborator

@rnyb rnyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

Copy link
Collaborator

@mferrera mferrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Highlighted some very minor nitpicks, but great documentation addition 😄👍

in complex carbonate reservoirs) project.

Output from casegen_upcars is in the form of Eclipse simulation models. These
models can be run to investigate impact of changing geological properties on
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick:

investigate the impact

Comment on lines 14 to 15
The script can generate various types of grid structure (tilting, dome, and
hull) amd throws. The input file is in yaml format.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick, maybe?

grid structure_s_

also

s/amd/and

@codecov-commenter
Copy link

Codecov Report

Merging #602 (ffecbd6) into main (dae697e) will not change coverage.
Report is 2 commits behind head on main.
The diff coverage is 100.00%.

❗ Current head ffecbd6 differs from pull request most recent head f74c25a. Consider uploading reports for the commit f74c25a to get more accurate results

@@           Coverage Diff           @@
##             main     #602   +/-   ##
=======================================
  Coverage   84.71%   84.71%           
=======================================
  Files          52       52           
  Lines        7510     7510           
=======================================
  Hits         6362     6362           
  Misses       1148     1148           
Files Changed Coverage Δ
src/subscript/check_swatinit/plotter.py 94.59% <ø> (ø)
...subscript/sw_model_utilities/sw_model_utilities.py 96.39% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@alifbe alifbe merged commit af51a0b into equinor:main Sep 19, 2023
@alifbe alifbe deleted the add-casegen-upcars-doc branch September 19, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants