Pin Sphinx < 7 and build without setuptools hook #549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #549 +/- ##
==========================================
- Coverage 86.21% 86.20% -0.02%
==========================================
Files 49 49
Lines 7045 7037 -8
==========================================
- Hits 6074 6066 -8
Misses 971 971
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
mferrera
changed the title
Sphinx 7 deprecates the usage of the `style` HTML key in templates and the sphinx_rtd_theme package has not yet been updated to address this change.
mferrera
force-pushed
the
deprecate-build_sphinx
branch
from
d541299 to
318e4d4
Compare
|
@mferrera will this resolve the issue that Sondre flag? I wonder why it only fails on subscript docs but not other documentation. |
|
Yep! |
|
It seems most other repositories have already pinned Sphinx. I have seen it pinned to 4, 5, 6 in various repositories. I'm more surprised that subscript has lasted so long without pinning 😅 |
alifbe
approved these changes
Jun 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sphinx >= 7 deprecates building docs through its setuptools hook and deprecates the
styleHTML key that is used by the sphinx_rtd_theme. The theme has not yet been updated to address this change.