Create tracecount arg not in header #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jokva
force-pushed
the
create-tracecount-arg-not-in-header
branch
3 times, most recently
from
7d38f49 to
e1b6069
Compare
|
This need a test before it can be merged. |
The spec object should take a list of sample intervals, not just a size, and the documentation should obviously reflect that.
jokva
force-pushed
the
create-tracecount-arg-not-in-header
branch
2 times, most recently
from
c314ceb to
873fffa
Compare
Add a common issues section in the readme, for frequently encountered problems, and possible solutions.
The cheeky trick of passing the number of traceheaders in the binary header when creating new files, in a field that is not dedicated to number-of-traces-per-file, doesn't work because it's only 16 bits and overflows very fast, and SEG-Y allows for 32-bits of traces (governed by traceno). Instead, pass the override-number-of-traces argument to the internal filehandle constructor explicitly, and only consider that number if the binary header is also passed. This fixes the issue reported in equinor#235
jokva
force-pushed
the
create-tracecount-arg-not-in-header
branch
from
873fffa to
2019c1e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #235