Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/82522 update yarn may 2021 #536

Merged
merged 36 commits into from
Jun 2, 2021

Conversation

janhagevold
Copy link
Contributor

@janhagevold janhagevold commented May 26, 2021

Description

  • code changes required for @equinor/eds-core-react, mainly removing destructuring objects. Popover now uses anchorEl.
  • eds updated Typography tokens (Reduced line-height on h1, h2 & h3)
  • config changes for webpack, add plugin setting for eds-core-react not finding process defined
  • config changes for jest, testEnvironment explicitly set to jsdom (faster node environment is now available and can be set on per file basis).
/**
 * @testEnvironment jsdom OR node
 */

  • config changes babel, to get rid of error messages when running tests
  • config changes husky, hooks are now found in .husky folder

Completes: AB#82522

Checklist:

  • I have performed a self-review of my own code.
  • I have linked my DevOps task using the AB# tag.
  • My code is easy to read, and comments are added where needed.
  • My code is covered by tests.

@github-actions github-actions bot added dependencies Pull requests that update a dependency file docker Pull requests that update Docker code invitation for punchout Changes to the IPO module missing test There doesnt seem to be a test associated with this preservation Changes to preservation module labels May 26, 2021
@janhagevold janhagevold merged commit 75d29a3 into master Jun 2, 2021
@janhagevold janhagevold deleted the feature/82522_-_update_yarn_may2021 branch June 2, 2021 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file docker Pull requests that update Docker code invitation for punchout Changes to the IPO module missing test There doesnt seem to be a test associated with this preservation Changes to preservation module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants