CI: Add script for running tests from github worklow #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slangeveld
commented
Jan 23, 2025
mferrera
approved these changes
Jan 23, 2025
ci/testrmsenv.sh
Outdated
| run_pytest () { | ||
| echo "Running fmu-tools tests with pytest..." | ||
| pushd $CI_TEST_ROOT | ||
| pytest -n 4 -vv -m "not skipunlessroxar" |
There was a problem hiding this comment.
My brain can't boolean today, but I think we want to include the the roxar tests (does this do that)?
There was a problem hiding this comment.
The intention here was to exclude it, to avoid calling the RMS API to often as discussed here https://github.com/equinor/rms-sys/pull/254
But open to include it if we want that.
There was a problem hiding this comment.
Saw your comment here equinor/xtgeo#1297
Will include the roxar tests 👍
ci/testrmsenv.sh
Outdated
Comment on lines
35
to
36
| echo "Installing test dependencies..." | ||
| pip install --upgrade --force-reinstall ".[tests]" |
There was a problem hiding this comment.
Future selves shall thank us for an isolated install 👍
slangeveld
force-pushed
the
267-add-test-rmsenv-script
branch
from
66e6924 to
fd674d2
Compare
slangeveld
added a commit
that referenced
this pull request
Feb 3, 2025
* CI: Add script for running tests from github worklow (#271) * CI: Install dependencies for `tests` * CI: Clone xtgeo testdata for tests * CI: Include roxar tests * CI: Use xtgeo-testdata from cache * TST: Use testdata path from test config
slangeveld
added a commit
that referenced
this pull request
Feb 11, 2025
* CI: Add script for running tests from github worklow (#272) * CI: Add script for running tests from github worklow (#271) * CI: Install dependencies for `tests` * CI: Clone xtgeo testdata for tests * CI: Include roxar tests * CI: Use xtgeo-testdata from cache * TST: Use testdata path from test config * TST: Tweak depth convert numerical stability One test case was commented out and this solution may not be robust on all machines. --------- Co-authored-by: mferrera <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves part of https://github.com/equinor/rms-sys/issues/267
Added a bash script that can be run from the github workflows to execute the
fmu-toolsunit tests towards an RMS Python Environment. The script copies the required test files, installs the test dependencies and runs the pytests. Note that the xtgeo-testdata files needed to run the tests are cached on the github actions runner som pointing to the pathXTGEO_TESTDATA_PATHwith the cached data should be sufficient to run the tests.Tests have been updated to be able to use the testdata path
XTGEO_TESTDATA_PATHset in the test config:XTGEO_TESTDATA_PATHin the commandpytest ./tests -n 4 -vv --testdatapath $XTGEO_TESTDATA_PATH.A testrun from can be seen here https://github.com/equinor/rms-sys/actions/runs/13006244695/job/36273691991