-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sample simgrid seismic as points #253
Merged
jcrivenaes
merged 3 commits into
equinor:main
from
jcrivenaes:sample-simgrid-seismic-aspoints
Nov 14, 2024
Merged
Sample simgrid seismic as points #253
jcrivenaes
merged 3 commits into
equinor:main
from
jcrivenaes:sample-simgrid-seismic-aspoints
Nov 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a80a1b8
to
ccb2dc2
Compare
ccb2dc2
to
874b772
Compare
713b847
to
34ff525
Compare
tnatt
reviewed
Nov 13, 2024
tnatt
reviewed
Nov 13, 2024
tnatt
reviewed
Nov 13, 2024
tnatt
reviewed
Nov 13, 2024
tnatt
reviewed
Nov 13, 2024
tnatt
reviewed
Nov 13, 2024
tnatt
reviewed
Nov 13, 2024
tnatt
reviewed
Nov 13, 2024
tnatt
approved these changes
Nov 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not too familiar with the SIM2SEIS workflow, but the functionality looks fine to me 🙂
Added some small comments for your consideration.
A particular use case for this is sampling seismic maps in 'sim2seis' work flows and out them as CSV('ish) files for ERT and Webviz.
c14c31a
to
af204d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will potentially remove several jobs/script in RMS and replace them with one python script. It also makes it possible to run this independent of RMS, hence it is linked to https://github.com/equinor/fmu-sim2seis/issues/27
Closes #223
https://link.excalidraw.com/readonly/LzQYxTHfLcviR8F7GLRW