BUG: fix 2 small bugs wrt to XTGeo 3.9.2 and Roxar/RMS API #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcrivenaes
force-pushed
the
bugfix-df-drop-issue
branch
2 times, most recently
from
0f5f5ea to
ec72b17
Compare
tnatt
reviewed
Aug 29, 2024
Comment on lines
8
to
23
| try: | ||
| import _roxar # type: ignore | ||
| from _roxar import Project # type:ignore | ||
| except ModuleNotFoundError: | ||
| try: | ||
| import _rmsapi as _roxar # type: ignore | ||
| from _rmsapi import Project # type:ignore | ||
| except ModuleNotFoundError: | ||
|
|
||
| class MockRoxar: | ||
| @property | ||
| def Project(self): | ||
| pass | ||
| class MockRoxar: | ||
| @property | ||
| def Project(self): | ||
| pass | ||
|
|
||
| _roxar = MockRoxar() | ||
| _roxar = MockRoxar() | ||
| Project = _roxar.Project |
There was a problem hiding this comment.
It seems to me that all of this is related to type hinting the project argument in the function. Could we just remove it and put Any as type instead as we do in the qcreset.py 🙂 ? for simplicity?
There was a problem hiding this comment.
I was thinking of that, but left it as it was your code initially; :-) I can change it to Any
This is due to change in xtgeo 3.9.2
jcrivenaes
force-pushed
the
bugfix-df-drop-issue
branch
from
ec72b17 to
e9f5685
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #216 and #215