Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update fmutools-publish-pypi.yml #211

Merged
merged 3 commits into from
Apr 23, 2024
Merged

Update fmutools-publish-pypi.yml #211

merged 3 commits into from
Apr 23, 2024

Conversation

jcrivenaes
Copy link
Collaborator

@jcrivenaes jcrivenaes commented Apr 23, 2024 •
edited
Loading

Use trusted pypi publishing, #210

Not sure how to test this prior to merge?

@jcrivenaes
Update fmutools-publish-pypi.yml
1607659 
Use trusted pypi publishing, #210
@jcrivenaes jcrivenaes requested a review from mferrera April 23, 2024 11:45
mferrera
mferrera approved these changes Apr 23, 2024
View reviewed changes
Copy link
Collaborator

@mferrera mferrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment for your consideration

.github/workflows/fmutools-publish-pypi.yml Show resolved Hide resolved
@mferrera
Copy link
Collaborator

mferrera commented Apr 23, 2024 •
edited
Loading

You may still need/want to have a

- name: Install build dependencies
  run: |
    pip install -U pip
    pip install build

step

@jcrivenaes jcrivenaes merged commit da1e354 into main Apr 23, 2024
28 checks passed
@jcrivenaes jcrivenaes deleted the add-trusted-publishing branch April 23, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mferrera mferrera mferrera approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jcrivenaes @mferrera