Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor QCProperties #128

Merged
merged 1 commit into from
Apr 13, 2021
Merged

Conversation

tnatt
Copy link
Collaborator

@tnatt tnatt commented Apr 13, 2021

Refactoring of QCProperties which includes:

API changes

  • Only properties of the same type (continous/discrete) allowed in a run. This avoids the confusion of having two dataframes whitin a QCProperties instance ref getting fraction per zone as a statistics for discrete parameter #111
  • No longer allowed to specify "csvfile" in the input dictionary
  • Statistics for discrete properties is now reported in fractions instead of percentages. Column names for discrete properties changed from "Percentage" and "Percentage_Weighted" to "Avg" and "Avg_Weighted" in alignment with the column names used for continous statistics.
  • A Pandas dataframe is returned when running an instance method for extracting statistics instead of a PropStat instance

Added functionality

  • A "range" option is added to filters to enable using continous properties as filters. It is also possible to add "range" as a value directly on a property to remove unwanted high/low values from the statistics.
  • "COUNT" added as a clolumn to continous statistics to be able to see sample size adding the number of points in the statisitcs  #112

This PR closes #123 #112 #127 #111

@tnatt tnatt requested a review from HansKallekleiv April 13, 2021 11:31
Copy link

@HansKallekleiv HansKallekleiv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Like the use of test classes 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation: qcproperties
2 participants