Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update GitHub actions workflow #91

Merged
merged 8 commits into from
Jul 14, 2020
Merged

Update GitHub actions workflow #91

merged 8 commits into from
Jul 14, 2020

Conversation

anders-kiaer
Copy link
Collaborator

@anders-kiaer anders-kiaer commented Jul 9, 2020 •
edited
Loading

GitHub cache is working in their latest action version.

Astroid/Pylint is also fixed upstream - bumping to latest version (which also uncovers some small issues with f-strings).

@anders-kiaer anders-kiaer requested a review from wouterjdb July 12, 2020 09:24
wouterjdb
wouterjdb approved these changes Jul 12, 2020
View reviewed changes
Copy link
Collaborator

@wouterjdb wouterjdb left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Just needs to pass build twice still...

Which it hasn't.....

@wouterjdb wouterjdb self-requested a review July 12, 2020 09:33
wouterjdb
wouterjdb requested changes Jul 12, 2020
View reviewed changes
Copy link
Collaborator

@wouterjdb wouterjdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failed build.

@wouterjdb
Copy link
Collaborator

Passed without cache. But crashed on pytest during the round where a cache was used on not being able to find norne_parameters.yml.

@anders-kiaer
Copy link
Collaborator Author

Looks like it fails due to missing input case data... which again is due to this line being part of build_environment.sh (which is not re-run when cache exists):

flownet/build_environment.sh

Line 32 in ec652b1

tar -zxvf tests/data/norne.tar.gz -C tests/data/

That line should probably be taken out of the build_environment.sh script, as it is not part of "building the Python environment". The test cases/models should soon also come from another repository (https://github.com/equinor/flownet-testdata) and not this one.

wouterjdb
wouterjdb previously approved these changes Jul 14, 2020
View reviewed changes
@wouterjdb wouterjdb dismissed their stale review July 14, 2020 10:15

My own

@wouterjdb wouterjdb merged commit 898f4b4 into equinor:master Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wouterjdb wouterjdb wouterjdb approved these changes

Assignees

@wouterjdb wouterjdb

@anders-kiaer anders-kiaer

Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anders-kiaer @wouterjdb