Fixes bug in analysis workflow #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
anders-kiaer
requested changes
Jul 2, 2020
anders-kiaer
approved these changes
Jul 3, 2020
edubarrosTNO
pushed a commit
to edubarrosTNO/flownet
that referenced
this pull request
Jul 3, 2020
edubarrosTNO
added a commit
that referenced
this pull request
Aug 21, 2020
* Makes analysis workflow optional * Missing part from previous PR #81 * Reduces number of inputs to analysis workflow * Renders input to workflow in ERT config file * Removes unnecessary import * Makes new arguments optional to work with run_pred * Fixes type of variable for path to reference simulation * Fixes path type variable in ahm * Revert back to path as string * Revert path back to string in ahm * Fixes derivation of absolute path * Fixes it for new configsuite version * Fixes for CI error on variable type * Fixes for CI error on variable type (2) * Formatting with black Co-authored-by: Ubuntu <egona@VM-Eduardo.430u41ciwbmupm0cbb0cjpnibd.fx.internal.cloudapp.net> Co-authored-by: Anders Fredrik Kiær <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #61.
A new way of loading data from the reference simulation (OPM-Flow/Eclipse) is added, using functionality from
flownet.data.from_eclipseinstead of the previous approach of fetching data from the observation file into dictionary which was causing the random order behavior