-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add brine p #417
Add brine p #417
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should add an item to the CHANGELOG stating that FlowNet now supports brine simulation.
Other that that it looks nice!
I commented all the places where a potential cumulative vector for salt could be added. I don't know enough about brine simulations to know if it is ever used by someone, but I see the vectors are available in OPM Flow, at least. If it is something that is not used at all we should not add them.
I followed your suggestions to generalise and to allow also for WSPT, WSIT, WSIR, similarly as done e.g. for water production/injection (WWXX). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one small thing in the observations.ertobs.jinja2 template and we should be good to go!
Many thanks for all the good suggestions. I removed the WSIR from WCONHIST. |
This PR continues PR #410 (add brine support)
This PR adds on top of P#410 the creation of WSALT entries in the HISTORY_SCHEDULE.inc
The flownet-testcases/ norne_salt (PR #50 of flownet-testcases repo) is used as testcase
Contributor checklist
- flownet-testcases/ norne_salt
CHANGELOG.md
.