Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix observation templates #391

Merged
merged 2 commits into from
Apr 30, 2021
Merged

Fix observation templates #391

merged 2 commits into from
Apr 30, 2021

Conversation

olelod
Copy link
Collaborator

@olelod olelod commented Apr 30, 2021 •
edited
Loading

The yamlobs jinja template has some bugs in it for writing observations of injection

Contributor checklist

  • 🎉 This PR closes WWIR quantity ignored in the analysis? #390.
  • 📜 I have broken down my PR into the following tasks:
    • Fix error im yamlobs templat
  • 🤖 I have added tests, or extended existing tests, to cover any new features or bugs fixed in this PR.
  • 📖 I have considered adding a new entry in CHANGELOG.md.
  • 📚 I have considered updating the documentation.

@olelod olelod marked this pull request as ready for review April 30, 2021 10:06
wouterjdb
wouterjdb requested changes Apr 30, 2021
View reviewed changes
Copy link
Collaborator

@wouterjdb wouterjdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a CHANGELOG item.

@wouterjdb wouterjdb added the bug Something isn't working label Apr 30, 2021
wouterjdb
wouterjdb approved these changes Apr 30, 2021
View reviewed changes
Copy link
Collaborator

@wouterjdb wouterjdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@olelod olelod merged commit aa361bf into equinor:master Apr 30, 2021
@olelod olelod deleted the i390-fix-errors-in-template branch April 30, 2021 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wouterjdb wouterjdb wouterjdb approved these changes

@anders-kiaer anders-kiaer Awaiting requested review from anders-kiaer

Assignees

@olelod olelod

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

WWIR quantity ignored in the analysis?
2 participants
@olelod @wouterjdb