Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add delta to SWL to calculate SWCR #379

Merged
merged 4 commits into from
Apr 21, 2021
Merged

Conversation

olelod
Copy link
Collaborator

@olelod olelod commented Apr 21, 2021

If you want to create a wide range for both SWL and SWCR there is a large chance for generating non-physical values, where SWCR is lower than SWL. This PR adds a parameter to the config yaml (defaulted to false), that provides the opportunity to calculate the SWCR from the SWL by adding a delta value.

If swcr_add_to_swcr is set to True the swcr parameter in the config yaml will be treated as a prior distribution for the delta value that will be added to SWL, not as a prior distribution for SWCR directly.


Contributor checklist

  • 🎉 This PR closes #ISSUE_NUMBER.
  • 📜 I have broken down my PR into the following tasks:
    • Add swcr_add_to_swl to config_parser
    • Update render_output for relative_permeability
  • 🤖 I have added tests, or extended existing tests, to cover any new features or bugs fixed in this PR.
  • 📖 I have considered adding a new entry in CHANGELOG.md.
  • 📚 I have considered updating the documentation.

@olelod olelod self-assigned this Apr 21, 2021
@olelod olelod added the enhancement New feature or request label Apr 21, 2021
@olelod olelod marked this pull request as ready for review April 21, 2021 13:17
Copy link
Collaborator

@wouterjdb wouterjdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@olelod olelod merged commit c66e97e into equinor:master Apr 21, 2021
olelod added a commit to olelod/flownet that referenced this pull request Apr 22, 2021
Add delta to SWL to calculate SWCR (equinor#379)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants