Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop Python 3.6 support #363

Merged
merged 4 commits into from
Mar 19, 2021
Merged

Drop Python 3.6 support #363

merged 4 commits into from
Mar 19, 2021

Conversation

wouterjdb
Copy link
Collaborator

@wouterjdb wouterjdb commented Mar 18, 2021 •
edited
Loading

Python 3.6 is getting closer to its end-of-life date (23 dec 2021). For an upcoming PR (#356) an updated version of scipy is used for which there is no longer support for Python 3.6. (also recent numpy versions have no longer Python 3.6 support...).

This PR drop Python 3.6 support for FlowNet.

Contributor checklist

  • 🎉 This PR closes no specific issue (but is needed for an upcoming PR Add option to distribute volume according to geometric distribution #356)
  • 📜 I have broken down my PR into the following tasks:
    • Bump all mentioning of Python 3.6 to Python 3.7
    • Update CHangelog.
  • 🤖 I have added tests, or extended existing tests, to cover any new features or bugs fixed in this PR.
  • 📖 I have considered adding a new entry in CHANGELOG.md.
  • 📚 I have considered updating the documentation.

@wouterjdb wouterjdb self-assigned this Mar 18, 2021
@wouterjdb wouterjdb marked this pull request as ready for review March 18, 2021 08:26
anders-kiaer
anders-kiaer requested changes Mar 18, 2021
View reviewed changes
Copy link
Collaborator

@anders-kiaer anders-kiaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Update readme at the same time?

@wouterjdb
Copy link
Collaborator Author

Good point. Done.

@wouterjdb wouterjdb merged commit 43b6bd4 into equinor:master Mar 19, 2021
@wouterjdb wouterjdb deleted the droppy36 branch March 19, 2021 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anders-kiaer anders-kiaer anders-kiaer approved these changes

@olelod olelod Awaiting requested review from olelod olelod is a code owner

Assignees

@wouterjdb wouterjdb

Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wouterjdb @anders-kiaer