Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved model generation #298

Merged
merged 16 commits into from
Jan 15, 2021
Merged

Conversation

wouterjdb
Copy link
Collaborator

@wouterjdb wouterjdb commented Jan 7, 2021

This PR fixes the issues described in #282 and #297.


Contributor checklist

@wouterjdb wouterjdb added the enhancement New feature or request label Jan 7, 2021
@wouterjdb wouterjdb self-assigned this Jan 7, 2021
@wouterjdb
Copy link
Collaborator Author

Currently this PR has implemented a smaller or larger than check for the angle - I'm not so sure this is actually the right way @olelod. I think what it would do is the following:

With only the larger than x you would remove:
image

If you also make it into a smaller than test, you'd remove:
image

That is not really what we are after?

@wouterjdb
Copy link
Collaborator Author

Conclusion discussion: @olelod @LonnekevB

Only expose angle, don't do the rest yet. Make new issue.

@wouterjdb wouterjdb marked this pull request as ready for review January 14, 2021 13:35
@wouterjdb wouterjdb requested a review from LonnekevB January 14, 2021 13:36
Copy link
Collaborator

@olelod olelod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wouterjdb wouterjdb merged commit 64edc2f into equinor:master Jan 15, 2021
@wouterjdb wouterjdb deleted the i282-longconnections branch January 15, 2021 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants