-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved model generation #298
Conversation
Currently this PR has implemented a smaller or larger than check for the angle - I'm not so sure this is actually the right way @olelod. I think what it would do is the following: With only the larger than x you would remove: If you also make it into a smaller than test, you'd remove: That is not really what we are after? |
Conclusion discussion: @olelod @LonnekevB Only expose angle, don't do the rest yet. Make new issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR fixes the issues described in #282 and #297.
Contributor checklist
Find good hyper parameters for test-data setCHANGELOG.md
.