Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix duplicate names in hyperopt parameters by using full yaml path #256

Merged
merged 3 commits into from
Nov 19, 2020
Merged

Fix duplicate names in hyperopt parameters by using full yaml path #256

merged 3 commits into from
Nov 19, 2020

Conversation

wouterjdb
Copy link
Collaborator

@wouterjdb wouterjdb commented Nov 19, 2020 •
edited
Loading

Insert a description of your pull request (PR) here, and check off the boxes below when they are done.

Contributor checklist

  • 🎉 This PR closes Hyperparameter run failing when identical keys are used #250.
  • 📜 I have broken down my PR into the following tasks:
    • Let entire path in yaml file be used as hyperparameter key
  • 🤖 I have added tests, or extended existing tests, to cover any new features or bugs fixed in this PR.
  • 📖 I have considered adding a new entry in CHANGELOG.md.
  • 📚 I have considered updating the documentation.

@wouterjdb wouterjdb self-assigned this Nov 19, 2020
@wouterjdb wouterjdb added the bug Something isn't working label Nov 19, 2020
@wouterjdb wouterjdb changed the title Entire path in yaml as name Fix duplicate names in hyperopt parameters by using full yaml path Nov 19, 2020
@wouterjdb wouterjdb marked this pull request as ready for review November 19, 2020 14:27
olelod
olelod approved these changes Nov 19, 2020
View reviewed changes
Copy link
Collaborator

@olelod olelod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

CHANGELOG.md Outdated Show resolved Hide resolved
@wouterjdb @olelod
Update CHANGELOG.md
5dcad90 
Co-authored-by: Ole Petter Lødøen <[email protected]>
@wouterjdb wouterjdb merged commit abc2dd2 into equinor:master Nov 19, 2020
@wouterjdb wouterjdb deleted the i25-fix-hyperparameter-names branch November 19, 2020 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olelod olelod olelod approved these changes

@anders-kiaer anders-kiaer Awaiting requested review from anders-kiaer

Assignees

@wouterjdb wouterjdb

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hyperparameter run failing when identical keys are used
2 participants
@wouterjdb @olelod