Adding possibility to change control modes in history matching #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olelod
changed the title
wouterjdb
requested changes
Oct 27, 2020
src/flownet/realization/_schedule.py
Outdated
| @@ -162,7 +162,7 @@ def _calculate_wconhist(self): | |||
| date=value["date"], | |||
| well_name=value["WELL_NAME"], | |||
| status=value["WSTAT"], | |||
| control_mode=self._control_mode, | |||
| control_mode=self._prod_control_mode, | |||
There was a problem hiding this comment.
Would it make sense to call this prod_control_mode further down the function as well for clarity?
There was a problem hiding this comment.
I just used the ones allready defined, but i agree with your comment about clarity.
src/flownet/realization/_schedule.py
Outdated
| @@ -197,6 +197,7 @@ def _calculate_wconinjh(self): | |||
| rate=value["WWIR"], | |||
| bhp=value["WBHP"], | |||
| thp=value["WTHP"], | |||
| target=self._inj_control_mode, | |||
There was a problem hiding this comment.
And then this inj_control_mode?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the possibility to change how the production wells are controlled in the WCONHIST keywords. This will not be controlled by one keyword in the config yaml.
Contributor checklist
CHANGELOG.md.