Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make FlowNet work with pyscal 0.6.x, and add possibility of using pyscal's SCALrecommendation #199

Merged
merged 28 commits into from
Oct 5, 2020

Conversation

olelod
Copy link
Collaborator

@olelod olelod commented Sep 22, 2020

In pyscal 0.6.x the krowend/krogend parameters are deprecated. Only kroend should be used now (both kro(swl) and kro(sgcr) should equal kroend).

pyscal also has the possibility of taking three sets of parameter values as input (low/base/high), and making SWOF/SGOF tables that are interpolated between the low/base/high inputs. This would potentially reduce the number of parameters passed on to ERT for history matching a lot.


Contributor checklist

@olelod olelod added the enhancement New feature or request label Sep 22, 2020
@olelod olelod self-assigned this Sep 22, 2020
@wouterjdb wouterjdb marked this pull request as ready for review October 1, 2020 07:37
@wouterjdb wouterjdb self-requested a review as a code owner October 1, 2020 07:37
Copy link
Collaborator

@wouterjdb wouterjdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - some minor things only.

.github/workflows/flownet.yml Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
src/flownet/parameters/_relative_permeability.py Outdated Show resolved Hide resolved
src/flownet/parameters/_relative_permeability.py Outdated Show resolved Hide resolved
src/flownet/parameters/_relative_permeability.py Outdated Show resolved Hide resolved
src/flownet/parameters/_relative_permeability.py Outdated Show resolved Hide resolved
src/flownet/parameters/_relative_permeability.py Outdated Show resolved Hide resolved
@olelod olelod requested a review from wouterjdb October 2, 2020 11:50
Copy link
Collaborator

@wouterjdb wouterjdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

There are some missing descriptions in the config parser setup, but that was already the case and outside of the scope of this PR. I've made an issue on this #204.

@olelod olelod merged commit 294a017 into master Oct 5, 2020
@olelod olelod deleted the i166-pyscal060 branch October 5, 2020 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants