-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make FlowNet work with pyscal 0.6.x, and add possibility of using pyscal's SCALrecommendation #199
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - some minor things only.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
There are some missing descriptions in the config parser setup, but that was already the case and outside of the scope of this PR. I've made an issue on this #204.
In pyscal 0.6.x the krowend/krogend parameters are deprecated. Only kroend should be used now (both kro(swl) and kro(sgcr) should equal kroend).
pyscal also has the possibility of taking three sets of parameter values as input (low/base/high), and making SWOF/SGOF tables that are interpolated between the low/base/high inputs. This would potentially reduce the number of parameters passed on to ERT for history matching a lot.
Contributor checklist
CHANGELOG.md
.