Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify ahm and pred ert subprocess call #125

Merged
merged 2 commits into from
Aug 21, 2020

Conversation

anders-kiaer
Copy link
Collaborator

No description provided.

@anders-kiaer anders-kiaer self-assigned this Aug 21, 2020
@anders-kiaer anders-kiaer requested a review from wouterjdb August 21, 2020 07:34
@anders-kiaer anders-kiaer marked this pull request as ready for review August 21, 2020 07:40
Copy link
Collaborator

@wouterjdb wouterjdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some minor comments that you are free to ignore

src/flownet/ert/_run_subprocess.py Show resolved Hide resolved
src/flownet/ert/_run_subprocess.py Show resolved Hide resolved
src/flownet/ert/_run_subprocess.py Outdated Show resolved Hide resolved
src/flownet/ert/_run_subprocess.py Outdated Show resolved Hide resolved
@anders-kiaer anders-kiaer merged commit df8b1d8 into equinor:master Aug 21, 2020
@anders-kiaer anders-kiaer deleted the subprocess_pred branch August 21, 2020 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants