Upgrade to pyqt6 #9860
Upgrade to pyqt6 #9860
Conversation
CodSpeed Performance ReportMerging #9860 will not alter performanceComparing Summary
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9860 +/- ##
==========================================
+ Coverage 91.62% 91.65% +0.03%
==========================================
Files 422 422
Lines 26466 26515 +49
==========================================
+ Hits 24249 24303 +54
+ Misses 2217 2212 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
JHolba
added
the
release-notes:maintenance
|
Have you checked whether the Qt6 binaries are actually present; ie. when running with komodo? |
All the .so files are installed together with the package when running pip install locally at least. Have not tried specifically with komodo. |
Upgrade from qtpy with pyqt5 to PyQt6. Using PyQt6 directly should give us better typing. PySide6 was tested, but was unstable.
…ved some leftovers from testing
|
We can fix this later, but the progress bar color changed: |
| if: inputs.os == 'ubuntu-latest' | ||
| run: | | ||
| sudo apt-get update | ||
| sudo apt-get install libegl1 |
There was a problem hiding this comment.
Are we sure this is necessary?
There was a problem hiding this comment.
it was for pyside6. I can remove it and see what happens with pyqt6
There was a problem hiding this comment.
it did not work without libegl1
| @@ -316,7 +319,7 @@ def __add_help_menu(self) -> None: | |||
| help_link_item = help_menu.addAction(menu_label) | |||
| assert help_link_item is not None | |||
| help_link_item.setMenuRole(QAction.MenuRole.ApplicationSpecificRole) | |||
| help_link_item.triggered.connect(functools.partial(webbrowser.open, link)) # type: ignore | |||
Upgrading to PyQt6 as Qt5 seems to be end of service since 2023-05-26 for non subscription holders.
https://www.qt.io/blog/qt-5.15-extended-support-for-subscription-license-holders
Approach
Change package to PyQt6 and fix all incompatibilities and typing
Tried PySide6(#9586) first, but it causes segfaults during testing.
git rebase -i main --exec 'pytest tests/ert/unit_tests tests/everest -n auto --hypothesis-profile=fast -m "not integration_test"')When applicable