Fix right_click external plotter flaky test

equinor · Jan 20, 2025 · 44b68e0 · 44b68e0
1 parent 1528d2e
commit 44b68e0
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/src/ert/gui/main_window.py b/src/ert/gui/main_window.py
@@ -151,6 +151,9 @@ def right_clicked(self) -> None:
             pw.show()
             self._external_plot_windows.append(pw)
 
+    def get_external_plot_windows(self) -> list[PlotWindow]:
+        return self._external_plot_windows
+
     def select_central_widget(self) -> None:
         actor = self.sender()
         if actor:

diff --git a/tests/ert/ui_tests/gui/test_main_window.py b/tests/ert/ui_tests/gui/test_main_window.py
@@ -9,10 +9,8 @@
 import numpy as np
 import pytest
 from qtpy.QtCore import Qt, QTimer
-from qtpy.QtGui import QWindow
 from qtpy.QtWidgets import (
     QAction,
-    QApplication,
     QCheckBox,
     QComboBox,
     QDoubleSpinBox,
@@ -650,11 +648,12 @@ def test_right_click_plot_button_opens_external_plotter(qtbot, storage, monkeypa
         button_plot_tool = gui.findChild(SidebarToolButton, "button_Create_plot")
         assert button_plot_tool
 
-        def top_level_plotter_windows() -> list[QWindow]:
+        def top_level_plotter_windows() -> list[PlotWindow]:
+            plot_windows = gui.get_external_plot_windows()
             top_level_plot_windows = []
-            top_level_windows = QApplication.topLevelWindows()
-            for win in top_level_windows:
-                if "Plotting" in win.title() and win.isVisible():
+
+            for win in plot_windows:
+                if "Plotting" in win.windowTitle() and win.isVisible():
                     top_level_plot_windows.append(win)
             return top_level_plot_windows