Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add --userdata-file to device/update #370

Merged

Conversation

dlotterman
Copy link
Contributor

Some preferential doc sting changes to highlight the ease of the recent changes to updating always-pxe

Also C+V, C+V's the --userdata-file code from device/create to device/update, making it easier to update complicated userdata formats for devices in place.

$ bin/metal device update -i SOMEDEVICEUUID --userdata-file /tmp/my-cloud-init.mime
+--------------------------------------+----------+-------------+--------+
|                  ID                  | HOSTNAME |     OS      | STATE  |
+--------------------------------------+----------+-------------+--------+
| 9ffac3bb-4e04-466b-a786-b703fe52fa7f | h-01     | Custom iPXE | active |
+--------------------------------------+----------+-------------+--------+

Passed make generate-docs 🤷 ?

@dlotterman dlotterman temporarily deployed to external October 24, 2023 17:04 — with GitHub Actions Inactive
@displague
Copy link
Member

@dlotterman I'm wondering if this PR was motivated by a bug that was recently addressed: #367 (comment)

A bare --always-pxe should have the behavior of enabling always-pxe, just as a bare --locked should lock the node.

When we were revisiting the Always PXE behavior, we did not look into if the Lock behavior had also been affected. (@cc @Vasubabu)

@displague displague changed the title fix: quick device update doc strings and feat: add --userdata-file to device/update feat: add --userdata-file to device/update Nov 9, 2023
@displague displague merged commit 2554db1 into equinix:main Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants