Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BSWH Integration- (Biospecimen) #882

Closed
Labels
Biospecimen Dashboard CCC Priority 1 Issues to be addressed in the current release Research Research Dashboard

Comments

@sonyekere
Copy link
Collaborator

Biospecimen repository will require an update for site Baylor Scott and White Health (BSWH) integration.

@sonyekere sonyekere changed the title BSWH - Biospecimen Integration BSWH Integration- Biospecimen Repo Feb 2, 2024
@sonyekere
Copy link
Collaborator Author

Thank you @erincschwartz for the below requirements.

**Baylor Scott and White Health needs collection and shipping locations added to the Biospecimen Dashboard. This a research site.

Need Concept IDs under:
BioSpm_Location_v1r0 (Collection Location, 951355211)
BioShip_LocalID_v1r0 (Location ID, site specific, 560975149)

The following need to be added to the dashboard drop downs
Collection Location: BSW Health and Wellness Center
Shipping Location: BSW Health and Wellness Center

Please add to the csv files following rules for other research locations.

@wyattks please add to BSI.**

@Gbarra9
Copy link
Collaborator

Gbarra9 commented Apr 1, 2024

Notes from BSWH Integration (Code Changes)

  • shared.js

    • siteFullNames
    • siteSpecificLocation
    • locationConceptIDToLocationMap
    • conceptIdToSiteSpecificLocation (specific locations, not site)
    • siteSpecificLocationToConceptId (specific locations, not site)
    • NameToKeyObj (This appears to not be referenced anywhere)
    • keyToNameAbbreviationObj
    • keyToNameObj
    • keyToNameCSVObj
    • keyToLocationObj (specific locations, not site)
    • siteLocations
  • fieldMapping.js:

    • collectionLocationMapping (specific locations, not site)
    • nameToKeyObj (specific locations, not site)
  • tubeValidation.js

    • siteSpecificTubeRequirements
  • welcome.js
    researchOnlySiteArray

@sonyekere sonyekere moved this from Backlog to Development in Connect Development and Support Apr 2, 2024
@brotzmanmj
Copy link
Collaborator

Update: Here are the sites BSWH would like to start with for research collection and shipping locations.

The one we listed above for BSW Health and Wellness Center should be listed instead as:
BCC- HWC
In addition they would like these four locations for collection and shipping:
BCC- All Saints (FW)
BCC- Plano
BCC- Worth St
BCC- Irving

Addresses for these are in email from Brittany if needed for the shipping manifests. @wyattks if you can add there here, that would be great, thanks.

@wyattks
Copy link
Collaborator

wyattks commented Apr 4, 2024

@sonyekere sonyekere added the CCC Priority 2 Issues will be prioritized in the upcoming/next release label Apr 15, 2024
@erincschwartz
Copy link
Collaborator

BSWH would also like the following added as a collection and shipping location:

NTX Biorepository- 3410 Worth St. Suite 530, Dallas, TX 75246

@Gbarra9
Copy link
Collaborator

Gbarra9 commented Apr 29, 2024

Here are the requested collection and shipping locations so far:

BCC- All Saints (FW)- 1307 8th Ave Ste 305, Fort Worth, TX, 76104
BCC- Plano- 801 E Plano Pkwy Ste 160, Plano, TX, 75074
BCC- Worth St.- 4001 Worth St , Dallas, TX, 75246
BCC- Irving- 2021 N MacArthur Blvd Ste 210, Irving, TX, 75061
BCC- HWC - 4500 Spring Ave , Dallas, TX, 75210
NTX Biorepository- 3410 Worth St. Suite 530, Dallas, TX 75246

I have a question about the manifest portion. What will the naming be for the "Study Team"? What will the email be for the different BSWH site location, will they be the same or different?

Below is a manifest example:

Image

@erincschwartz
Copy link
Collaborator

@Gbarra9 Please use the following information for the manifest
Study Team: BSWH Connect Study Team
Email: [email protected] The email will be the same for all BSWH site locations.

@Gbarra9
Copy link
Collaborator

Gbarra9 commented May 1, 2024

@Gbarra9 Please use the following information for the manifest
Study Team: BSWH Connect Study Team
Email: [email protected] The email will be the same for all BSWH site locations.

Will do, thanks @erincschwartz

@erincschwartz
Copy link
Collaborator

@Gbarra9 can you check to ensure BSWH only has access to Research Collection in the Dashboard, not to Clinical Collection at the start

@Gbarra9
Copy link
Collaborator

Gbarra9 commented May 22, 2024

Hi @erincschwartz, the code I have at the moment has BSWH with only research dashboard access.

Screenshot 2024-05-22 at 10 45 01 AM

@Gbarra9 Gbarra9 moved this from Development to Testing in Connect Development and Support May 23, 2024
@Gbarra9 Gbarra9 linked a pull request May 23, 2024 that will close this issue
@sonyekere sonyekere added CCC Priority 1 Issues to be addressed in the current release and removed CCC Priority 2 Issues will be prioritized in the upcoming/next release labels May 24, 2024
@erincschwartz
Copy link
Collaborator

@Gbarra9 I just met with BSWH to run through the Biospecimen Dashboard, there are edits needed for the Collection and Shipping Location lists.

They have requested the following updates to the Collection Location List:
Location BCC-HWC, BC ---update name to: BCC-HWC
Location BCC-All Saints (FW)---update to FW All Saints
Add new location: BCC- Fort Worth

The Shipping Locations are not appearing in Dev, so we could not move through a test shipment. This is what is showing up:

Image

BSWH would like all of the Collection Locations listed as Shipping Locations (with edited names and including the new collection location requested above)

They would also like these lists to appear in alphabetical order.

Please let me know when these changes are ready for Dev testing.

@brotzmanmj
Copy link
Collaborator

@erincschwartz Let's discuss the Fort Worth/All Saints requested changes

@brotzmanmj
Copy link
Collaborator

@Gbarra9 please hold on this request until we get clarification from BSWH.

@erincschwartz
Copy link
Collaborator

@Gbarra9 After communicating with BSWH, we do not need to add BCC- Fort Worth as a new collection and shipping location (will do this in a later release).

Please do work to update the name of BCC-HWC, BC location, removing the BC at the end. This location name should just be BCC-HWC

Image

And, the shipping locations do need to be added, as mentioned above.

@Gbarra9
Copy link
Collaborator

Gbarra9 commented May 29, 2024

@Gbarra9 After communicating with BSWH, we do not need to add BCC- Fort Worth as a new collection and shipping location (will do this in a later release).

Please do work to update the name of BCC-HWC, BC location, removing the BC at the end. This location name should just be BCC-HWC

Image

And, the shipping locations do need to be added, as mentioned above.

@erincschwartz Thanks, I'll start working on this.

@erincschwartz
Copy link
Collaborator

Adding @rebexxxxxx to this issue since the Collection and Shipping location names will need to be updated in the Data Dictionary when complete.

@Gbarra9
Copy link
Collaborator

Gbarra9 commented May 31, 2024

@Gbarra9
Copy link
Collaborator

Gbarra9 commented May 31, 2024

@erincschwartz The updates are in dev.

@erincschwartz
Copy link
Collaborator

@Gbarra9 Shipping locations look good and worked for Jan to ship a collection. I received the collection in the Dashboard and Shipping Manifest and receipt csv file appeared as expected.

Can you do a check of the backend data and make sure the derived variables look right? Connect ID: 6391301439 Collection ID: CXA669944

@Gbarra9
Copy link
Collaborator

Gbarra9 commented Jun 5, 2024

@Gbarra9 Shipping locations look good and worked for Jan to ship a collection. I received the collection in the Dashboard and Shipping Manifest and receipt csv file appeared as expected.

Can you do a check of the backend data and make sure the derived variables look right? Connect ID: 6391301439 Collection ID: CXA669944

The data looks as expected on the backend. I noted the values and highlighted green for missing keys.
https://app.box.com/s/shrt7jb9o9powv768u04rj02eqa3fu9n

@erincschwartz
Copy link
Collaborator

@Gbarra9 I reviewed the backend data document linked above, all derived variables look good. Please note, in the document it states: <265193023>SrvBLM_ResSrvCompl_v1r0 (Blood/urine/mouthwash combined research survey status) - Started (615768760); Firestore and BQ show the status for this variable as 'not started' (which is the expected status)

@Gbarra9
Copy link
Collaborator

Gbarra9 commented Jun 11, 2024

@erincschwartz I'm going to edit the document as 'not started'

@wyattks
Copy link
Collaborator

wyattks commented Jun 21, 2024

Stage testing is complete. Ready for Prod

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment