Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache requests #132

Merged
merged 5 commits into from
Sep 24, 2024
Merged

Cache requests #132

merged 5 commits into from
Sep 24, 2024

Conversation

sbfnk
Copy link
Collaborator

@sbfnk sbfnk commented Sep 18, 2024

Implements caching of HTTP requests using the memoise package, closing #51 - caching happens within sessions and documentation has been added for how to preserve surveys between sessions, closing #119

Perhaps an ideal situation would cache between sessions but I don't know how to do that without adding substantial complexity (and writing to the user directory, which they might not want).

@sbfnk sbfnk requested a review from Bisaloo September 18, 2024 11:30
@sbfnk sbfnk enabled auto-merge (squash) September 18, 2024 12:39
This was linked to issues Sep 18, 2024
@sbfnk sbfnk mentioned this pull request Sep 20, 2024
22 tasks
Copy link
Contributor

@Bisaloo Bisaloo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not used memoise in this way before but after testing locally, it seems to work well indeed, including when the internet is disconnected after cache creation.

@sbfnk sbfnk merged commit e575c5b into main Sep 24, 2024
9 checks passed
@sbfnk sbfnk deleted the cache-requests branch September 24, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document download/load workflow Add caching for HTTP resources
2 participants