Backward-compatible changes pre-contactmatrix integration #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To ensure output class is consistent no matter `counts` value
|
@Bisaloo Is this ready for review/merge (once trailing whitespace has been cleared)? I believe that this doesn't change any of the matrices but I would want to verify this to be sure - should we add some snapshot tests to facilitate this in the future? |
Closed
|
Just looking at the conflicts now. |
|
Snapshot test failure is due to different print methods between |
|
@Bisaloo can we merge? |
|
Yes, sound good. Further changes can be added in follow up PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes in this PR should be (mostly) backward-compatible. A follow up PR will propose breaking changes integrating socialmixr with contactmatrix.